`command` doesn't work properly when ran from a variable

[SArpnt]

`command` doesn't work properly when ran from a variable

[faho]

Even if we did that, setting $EDITOR like that would still be a bad idea - it's also used outside of fish, and e.g. git sure won't know what a command kak is.

I would rather figure out that a variable expands to command or builtin and error out.

[faho]

You want either command $EDITOR or set -gx EDITOR (command -s kak) -c global.

The reason command foo doesn't work in a variable is because it's syntactically important, just like e.g. if won't work there.

[SArpnt]

could this give a better error message? even unknown command: command i think would make more sense. what's actually happening when you do this?

[faho]

command is both a keyword (for command foo) and a builtin (for command --search foo and command --help).

What you are running is effectively builtin command kak -c because it skips the keyword step.

[krobelus]

maybe we can make it a regular builtin, I don't off-hand see an advantage to decorators being keywords except maybe easier implementation. Things like if are different because it kind of needs to be known before variable expansion.