Giter Site home page Giter Site logo

Crash on vim mode: `/src/input.cpp:367: failed assertion: event_storage_.empty() && "event_storage_ should be empty"` about fish-shell HOT 7 CLOSED

TonalidadeHidrica avatar TonalidadeHidrica commented on September 25, 2024
Crash on vim mode: `/src/input.cpp:367: failed assertion: event_storage_.empty() && "event_storage_ should be empty"`

from fish-shell.

Comments (7)

zanchey avatar zanchey commented on September 25, 2024 1

If you can install the fish-dbgsym package, I think you'll at least get symbols, though it's pretty clear where this assert is firing.

from fish-shell.

mqudsi avatar mqudsi commented on September 25, 2024 1

If you don't have a reproducer, it would be best if you could build and install the latest release. We still have that assertion in the now-rust codebase, so the bug could still be present.

from fish-shell.

mqudsi avatar mqudsi commented on September 25, 2024 1

Yup.

from fish-shell.

TonalidadeHidrica avatar TonalidadeHidrica commented on September 25, 2024

I'll do that and tell you results once I get them. But after all, asking just in case, is it useful? I guess the next version will be the rewritten-in-Rust release. Now that the code is rewirtten, the bug may not exist in the next release.

from fish-shell.

krobelus avatar krobelus commented on September 25, 2024

a deterministic reproducer would be great. It might be fixed in latest master but we don't know yet. With a reproducer that's easy to test

from fish-shell.

TonalidadeHidrica avatar TonalidadeHidrica commented on September 25, 2024

You mean from the master branch instead of 3.7.1 tag?

from fish-shell.

krobelus avatar krobelus commented on September 25, 2024

This is fixed since the new logic keeps self.event_storage always empty (only the heap allocation is reused but only after being swapped into a local variable).
If it is decided that we have a patch release then we can add it

from fish-shell.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.