Comments (12)
The actual approach is that all the requests against TourGuide must be authenticated using a token
from Keyrock. @FiwareULPGC @jmcanterafonseca, should we change the actual approach and let the user get restaurants, reviews and reservations without being logged in? Take into account that if doing this, we should also disable the edit/create buttons, hide the sections 'my reservations' and 'my reviews' and so on.
from tutorials.tourguide-app.
I would keep this issue open and let analyze it later as we have other priorities
from tutorials.tourguide-app.
I think we should get back to this. Guys, what are your thoughts? @FiwareULPGC, would this be a huge change in the client? From the server side, the change shouldn't be a big deal.
Still, IMHO, the actual approach makes the user interacts with the Log-in - oauth - IdM authorization, and this change can make the user run the application and not interact with that feature.
from tutorials.tourguide-app.
Hi!
We think that it would not be too complicated to adapt the client to the proposed approach.
If we are going to implement it in a close future, if it is possible, it should be nice to know it in advance, to take it in care for the next planned client refactor and avoiding to refactor the client twice.
Thank you!
from tutorials.tourguide-app.
Thanks for the feedback! It was planned to be done in this sprint, but I'm afraid is too bit late (we have one week left for this sprint). Do you think is it feasible? If not, @jmcanterafonseca, should we move it to the next sprint?
from tutorials.tourguide-app.
yup
2016-04-21 19:08 GMT+02:00 Alberto Martín [email protected]:
Thanks for the feedback! It was planned to be done in this sprint, but I'm
afraid is too bit late (we have one week left for this sprint). Do you
think is it feasible? If not, @jmcanterafonseca
https://github.com/jmcanterafonseca, should we move it to the next
sprint?—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#35 (comment)
from tutorials.tourguide-app.
@FiwareULPGC, sever change for this issue is done #92 (waiting for review)
from tutorials.tourguide-app.
We have tested your branch (added as remote and merged with a new branch from develop), and the client can't get information if the user is not logged in.
We have checked that the last commit is 98f96ed (the same that the PR).
Here we detail the steps that we use to test the PR:
Get PR:
git remote add albertinisg https://github.com/albertinisg/tutorials.TourGuide-App.git
git fetch --all
git checkout develop
git pull
git checkout -b test-pr96
git merge albertinisg/feature/allow-get-all
Build the docker image:
docker build -t tourguide-pr92 .
Modify tourguide image:
tourguide:
image: tourguide-pr92
Launch the tourguide app:
docker-compose pull
docker-compose up
Access to the application using Firefox:
Make a request (without log in):
AJAXRequest.get('http://tourguide/api/orion/restaurants/', function(data){console.log(data)}, function() {alert('Could not retrieve restaurants');});
The error message is raised.
Log in and repeat the request:
AJAXRequest.get('http://tourguide/api/orion/restaurants/', function(data){console.log(data)}, function() {alert('Could not retrieve restaurants');});
The response with all restaurant data is printed in the console.
from tutorials.tourguide-app.
The image is not built (yet) in dockerhub with the changes, so you need to add the changes mapping the host in the docker-compose file (using volumes
):
tourguide:
image: fiware/tutorials.tourguide-app:latest
hostname: tourguide
links:
- orion
- idm
- pepwilma
- idasiotacpp:idas
environment:
- ORION_HOSTNAME=pepwilma
- ORION_NO_PROXY_HOSTNAME=orion
- ORION_PORT=1026
- ORION_PEP_ENABLED=true
- IDAS_PORT=8080
- ORION_SUBSCRIPTIONS_ENABLED=false
- SENSORS_GENERATION_ENABLED=false
- SENSORS_FORCED_UPDATE_ENABLED=false
volumes_from:
- idm
volumes:
- ../../../tutorials.TourGuide-App:/home/tourguide/tutorials.TourGuide-App
from tutorials.tourguide-app.
We have followed your indications and we could test it properly (after installing grunt). The client can get information even if the user is not logged in.
We also tested forbidden operations like delete and they returned 404 errors (maybe you could consider to return 403 errors instead)
Apart from the returned error codes it LGTM.
from tutorials.tourguide-app.
I'll open an issue to check that and re-asign this one to @FiwareULPGC . Thanks for the feedback!
from tutorials.tourguide-app.
Implemented via #117
from tutorials.tourguide-app.
Related Issues (20)
- move docker-compose.yml to the root directory of the app HOT 1
- docker-compose.yml has commented code without explanation HOT 1
- move data in Orion to default tenant HOT 1
- Use pep proxy to protect Orion Context Broker HOT 2
- Restaurant filter by date returns wrong timestamp
- Reconsider how IDAS is integrated HOT 3
- add new IDAS image to the Tour Guide
- remove pep proxy from docker-compose
- change name from 'idm' to 'keyrock' in the docker-compose.yml file HOT 1
- Add container_name to all containers in docker-compose
- Use cygnus official image
- change attribute type `date` to `DateTime` to align with Orion Context Broker HOT 1
- Doc improvement: subservice details in context base HOT 1
- Help! Deployment always failed. HOT 11
- Help! Deployment failded HOT 1
- How to add the container IP address to hosts file to make it reachable on Windows 8 HOT 6
- Fix list-reviews-by-organization to return the right values HOT 1
- Generate franchises not randomly HOT 1
- Do not display "write review" option if the user belongs to a franchise.
- Deployment on Fiware Cloud HOT 17
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tutorials.tourguide-app.