`get_value<int>()` and `get_value<float>()` reporting floating point underflow on value 0

[ARessegetesStery]

`get_value()` and `get_value()` reporting floating point underflow on value 0

from fkyaml.

[fktn-k]

@ARessegetesStery
OK. I'm looking forward to the fruits.
Feel free to ask anything.
There are a lot of templates along the way to the conversions, so it may be hard to understand.

whether it is possible to read

someint: 1

with a float in c++. I guess this will make the library easier to use.

I like it. Reasonable and intuitive.
It's also close to the way primitives are handled in C++.

[fktn-k]

@ARessegetesStery
Thanks for the updates and sorry for your computer...
And no worries. I just wanted to help if you were being stucked somewhere due to this library.
So anyway, take your time!

there's no need to wait for my updates

Thanks for your concern, but honestly I just couldn't spare enough time for this project lol

[fktn-k]

@ARessegetesStery
Thanks for filing a issue.
I'll share what I've found while reproducing the issue.
Regarding the underflow check for floating point values, I've found a bug where the implementation mistakenly call std::min(), not std::lowest(), to get the minimum possible value of a target type.
So getting floating point values equal to/less than 0 will emit the same error.

[ARessegetesStery]

@fktn-k Thanks for sharing the fix! I haven't looked into the source code and jumped to the conclusion lol.

[fktn-k]

@ARessegetesStery
Oh I stole the fun part, sorry. LOL
Actually, I couldn't have time to even reproduce the ingeter version of the bug.

I see you forked this repository, are you trying to fix it?
If so, that's very welcome.

[ARessegetesStery]

@fktn-k Oh thanks for explaining - Glad to see your insights on the problem :)
Yeah I am planning to spend some time this weekend test this thoroughly and see if I can figure out a fix.
Also I am trying to see if this can be made more compatible, for example whether it is possible to read

someint: 1

with a float in c++. I guess this will make the library easier to use.

[fktn-k]

@ARessegetesStery
How does the investigation goes?
Maybe it's too complicated to handle in a single PR.
If so, we can separate the issue into a bugfix and improvements.
Like first just fixing the bug in conversions, and then adding improvements like you mentioned above.

[ARessegetesStery]

@fktn-k
Sorry for the slow progresses - my computer somewhat broke last week and the new one is right on the way. Things should become much smoother after that.
Yep indeed I have opened issues for all features, separately, on my forked repo. If you want, I can also copy them here. For each fix I will open a separate pull request for clarity.
Also since github now has auto-sync functionalities for forked branches there's no need to wait for my updates to push your other commits to the main branch. I can sync the progress (and merge them if necessary) within a couple of clicks :)