Switch with internal label sometimes too narrow on Windows

[flandreas]

Switch with internal label sometimes too narrow on Windows

[flandreas]

I can confirm that changing the parameter in TextRenderInfoFactoryJvm improves things on Windows, and macOS is still the same (correct). However, I've also noticed that on Windows, the overline's lengths depend heavily on the zoom factor. But this seems to be the case independent on the parameter in TextRenderInfoFactoryJvm.

Recording.2024-04-23.195205.mp4

It also looks like font rendering by itself on Windows is quite unstable with changing zoom factors - with small zoom factors, text rendering gets quite "rough". Much rougher than on macOS.

I'm not an expert in these topics neither, so I guess we can change the parameter to improve some things, and others at least don't get worse.

[fpw]

As an alternate solution, it would be cool if the user could just drag the switch rectangle size themselves. For situations like the above, it would be more aesthetically pleasing if the switches all had the same size.

[fpw]

My Java days are long gone, but I noticed that KEY_FRACTIONALMETRICS is not explicitly set on the Graphics2D context. Doesn't that mean that the implementation will decide what's best, i.e. depending on the DPI setting?

This could be relevant because TextRenderInfoFactoryJvm just assumes that it's off when creating the FontRenderContext for measuring. For testing, I changed the last parameter from false to true and that's enough to make it look correct:

But this also improves various other little things, e.g. before:

After:

I believe the FontRenderContext should take the actual settings into account rather than making static assumptions. But as I said - not an expert on this topic, just a wild guess.

[fpw]

The rough zooming improves by actually enabling the rendering hint for fractional rendering. I suggest this:
g.setRenderingHint(RenderingHints.KEY_FRACTIONALMETRICS, RenderingHints.VALUE_FRACTIONALMETRICS_ON)
in combination with the true parameter in TextRenderInfoFactoryJvm.

I think the current default implementation is to leave it up to Windows GDI.