Bucket upload folder still not unique

[flank]

Bucket upload folder still not unique

[renas]

Please submit a PR so it looks exactly as you want. Thanks for sharing ideas and reporting issues.

…

On May 31, 2017 1:14 PM, "bootstraponline" ***@***.***> wrote: I just need to understand the issue :) here is the issue: # Copyright 2017 Google Inc. All Rights Reserved.## Licensed under the Apache License, Version 2.0 (the "License");# you may not use this file except in compliance with the License.# You may obtain a copy of the License at## http://www.apache.org/licenses/LICENSE-2.0## Unless required by applicable law or agreed to in writing, software# distributed under the License is distributed on an "AS IS" BASIS,# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.# See the License for the specific language governing permissions and# limitations under the License.## code from api_lib/firebase/test/arg_validate.pydef _GenerateUniqueGcsObjectName(): """Create a unique GCS object name to hold test results in the results bucket. The Testing back-end needs a unique GCS object name within the results bucket to prevent race conditions while processing test results. By default, the gcloud client uses the current time down to the microsecond in ISO format plus a random 4-letter suffix. The format is: "YYYY-MM-DD_hh:mm:ss.ssssss_rrrr". Returns: A string with the unique GCS object name. """ return '{0}_{1}'.format(datetime.datetime.now().isoformat('_'), ''.join(random.sample(string.letters, 4))) I'm happy to submit a pull request if you'd like. The fix you submitted (new Random().nextInt(50000000)) works but I would prefer to match the SDK in this case. 2017-05-31_17:19:36.431540_hRJD 2017-05-26_03:50:54.863502_AQmT 2017-05-30_13:33:02.233525_fTnd I would rather not write scripts to handle a special naming convention just for flank. Hope that makes sense. Thanks for all your work on the test runner. I appreciate the bug fixes and new features. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#16 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAKGpcMGlZqvQkBFG9SncPIr0rwT3bwyks5r_co-gaJpZM4NsA3C> .

[renas]

We also add a hash code of the project name.

• "_" + getConfigurator().getProjectNameHash()

[bootstraponline]

the project name is static so that's not helpful? Is there a reason for not adopting the same folder naming strategy as the official SDK?

[renas]

I just need to understand the issue :) If it's the same project team working on a project then why would the bucket name need to be unique? Our thought is that it should be unique per project.

…

On Wed, May 31, 2017 at 11:31 AM, bootstraponline ***@***.***> wrote: the project name is static so that's not helpful? Is there a reason for not adopting the same folder naming strategy as the official SDK? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#16 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAKGpSa9pmwadwimZrMOzR8ITcXWZoKyks5r_bH3gaJpZM4NsA3C> .

[bootstraponline]

I just need to understand the issue :)

here is the issue:

# Copyright 2017 Google Inc. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#    http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
# code from api_lib/firebase/test/arg_validate.py
def _GenerateUniqueGcsObjectName():
  """Create a unique GCS object name to hold test results in the results bucket.

  The Testing back-end needs a unique GCS object name within the results bucket
  to prevent race conditions while processing test results. By default, the
  gcloud client uses the current time down to the microsecond in ISO format plus
  a random 4-letter suffix. The format is: "YYYY-MM-DD_hh:mm:ss.ssssss_rrrr".

  Returns:
    A string with the unique GCS object name.
  """
  return '{0}_{1}'.format(datetime.datetime.now().isoformat('_'),
                          ''.join(random.sample(string.letters, 4)))

I'm happy to submit a pull request if you'd like. The fix you submitted (new Random().nextInt(50000000) ) works but I would prefer to match the SDK in this case.

2017-05-31_17:19:36.431540_hRJD
2017-05-26_03:50:54.863502_AQmT
2017-05-30_13:33:02.233525_fTnd

I would rather not write scripts to handle a special naming convention just for flank. Hope that makes sense.

Thanks for all your work on the test runner. I appreciate the bug fixes and new features.