fleetctl - error setting up Fleet: '@' character not allowed in usernames

[fleetdm]

fleetctl - error setting up Fleet: '@' character not allowed in usernames

[noahtalerman]

I encounter the same error message when I reproduce the steps you've outlined. Great catch.
Allowing for the email to be used as the username while the username is not allowed to have '@' characters seems like a difficult loop.
With what prior release of Fleet had you been successful with this setup?

[defensivedepth]

Currently running 3.1.0 and it works fine.

[noahtalerman]

I just attempted setup with Fleet 3.1.0 via fleetctl without specifying a username. I got the same error. I'm not sure why this error doesn't occur when you setup with 3.1.0, because it appears that usernames with '@' characters have been invalid even before 3.1.0.

I'm going to investigate further.

[defensivedepth]

Here is the Dockerfile we use:

https://github.com/Security-Onion-Solutions/securityonion-image/blob/master/so-fleet/Dockerfile

And the Fleet setup script: https://github.com/Security-Onion-Solutions/securityonion/blob/master/salt/common/tools/sbin/so-fleet-setup#L18

[defensivedepth]

7c923d9#diff-ab346cdbec51e188f9dd8d33a02497daeba0ad7b5ecea879a9da798eb3bf8f0a

[zwass]

Good find, Josh. Looks like we were always enforcing no @ in username for every user besides the first one (or maybe just attempting to) and copied that validation over in the commit you found.

I think we can go ahead and remove this requirement for all users.