Giter Site home page Giter Site logo

Comments (2)

erka avatar erka commented on June 7, 2024 1

Flipt doesn't take envs into account.. It probably should do something like

resource.New(ctx,
	resource.WithSchemaURL(semconv.SchemaURL),
	resource.WithAttributes(
		semconv.ServiceNameKey.String("flipt"),
		semconv.ServiceVersionKey.String(info.Version)),
	resource.WithFromEnv(),
)

from flipt.

yquansah avatar yquansah commented on June 7, 2024

@piclemx Hello, thanks for filing! 👋

From a quick look at the codebase on OTEL's side. It seems as though if you do set that OTEL_SERVICE_NAME environment variable it would be respected: https://github.com/open-telemetry/opentelemetry-go/blob/cd289eed0dd8ae1d6ffff904864dc1dc2a84c980/sdk/resource/env.go#L34

Is it not working as expected?

from flipt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.