Use of Object.assign disallows deep merge e.g. changing the arrow classNames only

[floating-ui]

Use of Object.assign disallows deep merge e.g. changing the arrow classNames only

[rosskevin]

BTW - this I ran into this because of a common SCSS lint rule:
SelectorFormat: Selectorpopper__arrowshould be written in lowercase with hyphens

Perhaps a default class change to popper-arrow wouldn't hurt?

[FezVrasta]

I'm following the BEM convention for the class names.
You can define it in your project but then I think you will have problems with the rest of the CSS
https://github.com/brigade/scss-lint/blob/master/lib/scss_lint/linter/README.md#selectorformat

I think we should find a better polyfill which supports deep merging.
Or better, write a deepMerge function that uses Object.assign.
(And maybe make the polyfill optional to allow people to rely on browser support)

[FezVrasta]

@rosskevin please may you try the object-deep-assign branch and let me know if it fixes the problem?

[rosskevin]

@FezVrasta this test case was updated with your branch and still doesn't work.

[FezVrasta]

Ok I'm sure now it works :)

I've changed arrow.classNames with arrowClassNames so there's not an additional level of deepness and everything works fine.
All the "deep merge" functions I have found was buggy and very big.