Giter Site home page Giter Site logo

Comments (9)

FezVrasta avatar FezVrasta commented on May 13, 2024 2

@nadiam84 The first example doesn't work because it's using viewport as boundaries element, but it's inside a scrolling div. Setting as boundariesElement the scrolling div everything works fine.
How would you solve this problem? Automatically setting the boundariesElement to the scrolling div or just asking users to properly define the boundaries?

https://codepen.io/FezVrasta/pen/akQpbW

Example 2 is fixed in the same way:
http://codepen.io/FezVrasta/pen/oLQBgp


PS: Actually the current behavior is the one suggested in the popper.js.org examples, all the examples ask to specify the boundariesElement if the container is scrollable.

from floating-ui.

adevnadia avatar adevnadia commented on May 13, 2024 1

1st and 2nd are wierd, 3rd is working correctly

from floating-ui.

FezVrasta avatar FezVrasta commented on May 13, 2024

Can you confirm that the problem is caused by the big margin applied to the target?

from floating-ui.

adevnadia avatar adevnadia commented on May 13, 2024

Doesn't look like it. Updated the CodePen, made it without margins. Still the same issue.

from floating-ui.

FezVrasta avatar FezVrasta commented on May 13, 2024

The 2nd and 3rd examples work correctly, right?

from floating-ui.

FezVrasta avatar FezVrasta commented on May 13, 2024

Disabling preventOverflow the problem is fixed so I guess it could be related to #58

from floating-ui.

FezVrasta avatar FezVrasta commented on May 13, 2024

Ok the problem is not related to #58, I'm gonna investigate it right now.

from floating-ui.

FezVrasta avatar FezVrasta commented on May 13, 2024

To summarize, we need to add scrollingParent as allowed boundariesElement value.

This will be the new default value and will always point to the closest scrollable parent (overflow !== initial)

from floating-ui.

FezVrasta avatar FezVrasta commented on May 13, 2024

Closing this in favor of #74.

from floating-ui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.