Un-representable inputs should raise an error

[DanielHeath]

Un-representable inputs should raise an error

[jmettraux]

Hello,

thanks for this report.

Fugit.parse is not supposed to raise an ArgumentError on invalid input, it simply returns nil. Fugit.do_parse will raise on invalid input.

The fugit nat "every" constructs produces Fugit::Cron instances. For example "every 3 hours" is turned into "0 */3 * * *". It breaks quickly as you noticed, with "every 17 hours" turned into "0 */17 * * *" which, in fact, corresponds to "every day at midnight and at 5 pm".

I am OK with returning nil / raising an ArgumentError for "every 27 hours", but for "every 17 hours", I lean towards returning nil for Fugit.parse("every 17 hours", strict: true), as seen in ec91e88

Would that suit you?

Kind regards.

[DanielHeath]

strict: true would do it, yeah.

[jmettraux]

You're welcome.

[DanielHeath]

🎉 Thank you!