Infinite loop when don't keep activities is enabled

[florent37]

Infinite loop when don't keep activities is enabled

[PhilippeBoisney]

I confirm.

[whalemare]

Still reproduced on implementation 'com.github.florent37:inline-activity-result:1.0.2

[victor-denisenko]

Hi

With option "don't keep activities" activity that call InlineActivityResult#startForResult() dies and ActivityResultFragment lose "listener" field value.

I think we cannot implement same behavior as default Activity#startActivityForResult(). Because, in that way, we must store ActivityResultFragment.ActivityResultListener interface througth death and recreation of process that cause memory leak (because listener stores link to context and cannot be saved in Bundle).

I didnt find way how to bount new activity with new ActivityResultFragment#onActivityResult() result. I looked at some other libraries, but they didnt solve this problem too.

But infinite loop can be fixed (i work on it).

[sevar83]

@victor-denisenko In theory the ViewModel of the caller should survive activity destruction (not process death) so if it is implementing ActivityResultListener and not its fragment/activity then the listener will survive too.
In case of a process death there won't be any memory leak because normally the entire app will be restarted. So preserving an arbitrary callback across process death is impossible.

[florent37]

google just fixed that : https://developer.android.com/training/basics/intents/result