Giter Site home page Giter Site logo

Comments (2)

kcochibili avatar kcochibili commented on May 24, 2024

I have the same issue, but before I share my solution I need to mention that this does not happen in all devices.
I am testing with a Samsung Galaxy s8 : issue occurs
and a Samsung Galaxy Tab s6: issue does not occur

The issue is caused by the inability of this library to properly handle dynamic dimensions assigned to the view. (just like you are using wrap_content in your case)
The circle view works correctly only when the height and width are the same. So to fix this, I run a code at runtime that makes the length of the longest side of the CircleVIew match the length of the shortest side.

Doing that fixes the issue. here is my code..

    public void fixCircleViewDimension(CircleView cv){
        cv.getViewTreeObserver().addOnGlobalLayoutListener(new ViewTreeObserver.OnGlobalLayoutListener() {

            @Override
            public void onGlobalLayout() {
                cv.getViewTreeObserver().removeOnGlobalLayoutListener(this);

                int width = cv.getWidth();
                int height = cv.getHeight();

                if(width > height){
                    FrameLayout.LayoutParams params = new FrameLayout.LayoutParams(height, height);
                    params.gravity = Gravity.CENTER;
                    cv.setLayoutParams(params);

                }else{
                    FrameLayout.LayoutParams params = new FrameLayout.LayoutParams(width, width);
                    params.gravity = Gravity.CENTER;
                    cv.setLayoutParams(params);
                }

            }
        });


    }

side note: replace the FrameLayaout with whatever the Parent of your CircleView is.

from shapeofview.

MostafaAryan avatar MostafaAryan commented on May 24, 2024

I have the same issue, but before I share my solution I need to mention that this does not happen in all devices.
I am testing with a Samsung Galaxy s8 : issue occurs
and a Samsung Galaxy Tab s6: issue does not occur

The issue is caused by the inability of this library to properly handle dynamic dimensions assigned to the view. (just like you are using wrap_content in your case)
The circle view works correctly only when the height and width are the same. So to fix this, I run a code at runtime that makes the length of the longest side of the CircleVIew match the length of the shortest side.

Doing that fixes the issue. here is my code..

    public void fixCircleViewDimension(CircleView cv){
        cv.getViewTreeObserver().addOnGlobalLayoutListener(new ViewTreeObserver.OnGlobalLayoutListener() {

            @Override
            public void onGlobalLayout() {
                cv.getViewTreeObserver().removeOnGlobalLayoutListener(this);

                int width = cv.getWidth();
                int height = cv.getHeight();

                if(width > height){
                    FrameLayout.LayoutParams params = new FrameLayout.LayoutParams(height, height);
                    params.gravity = Gravity.CENTER;
                    cv.setLayoutParams(params);

                }else{
                    FrameLayout.LayoutParams params = new FrameLayout.LayoutParams(width, width);
                    params.gravity = Gravity.CENTER;
                    cv.setLayoutParams(params);
                }

            }
        });


    }

side note: replace the FrameLayaout with whatever the Parent of your CircleView is.

Thanks for your response.

from shapeofview.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.