Ramda declarations, destructuring imports

[flow-typed]

Ramda declarations, destructuring imports

[jeffmo]

Support for both named and default exports inside a declare module will ship in 0.28 (no later than early next week). In the meantime, declare module bodies can only export one or the other:

Named via declare module.exports: {namedExport1: number, namedExport2: string};
Default via declare module.exports: MyDefaultExportHere;

In 0.28 and beyond, it will be possible to do:

declare module "MyModule" {
  declare export var namedExport1: number;
  declare export var namedExport2: string;
  declare export default MyDefaultExportHere;
}

[alexeygolev]

Just a quick update. Still working on it. Should be able to submit a PR before Monday. Found a couple of wrong typings along the way:-P

[ryyppy]

Actually, should Ramda be exported as a class with mixins?
I understand that the idea of those classes is to categorize the functions and mixins does a great job "spreading" those functions across one single export class... but to make named imports work, I guess we need to export an Object type?

[bwestergard]

@ryyppy Makes sense to me.

[alexeygolev]

@ryyppy @bwestergard I will look into it, unless anybody is up for a PR

[ryyppy]

I think @jeffmo said something about syntax support for named exports in declare module scope... maybe this will ease the work implementing named imports?

[alexeygolev]

@jeffmo I think we should wait till 0.28 ships then

[sebinsua]

Looks like [email protected] was released yesterday. Has anybody taken a look at getting this to work?

Is it possible to use declare export var [...] to output each of the functions within RType as named exports? (Aware that class was being used here to group related types.)

[mwalkerwells]

import Ramda from 'ramda';
const { curry, compose, reduce, keys, append } = Ramda;

@bwestergard / @jeffmo When I add line #2 (even if I remove the // @flow comment), flow instantly consumes 100% cpu after saving the file. Any idea why?

Using [email protected] & ramda_v0.21.x

[jeffmo]

@mwalkerwells: How long does it stay at 100% ? Also, how many flow worker processes do you see loaded in the background?

[mwalkerwells]

Really strange, but I can't get it to repro anymore. It was doing it all yesterday @ early today too. Atom command + click for modules wouldn't work in the meantime as well. It had 1/4 processes pegged @ 100% indefinitely iirc.

[alexeygolev]

@sebinsua: Working on it now. Hope to create a PR later today/tomorrow
Will also fix some bugs like empty generics introduced by [email protected]

[alexeygolev]

#188
that took me a while:)

[alexeygolev]

This can be closed I guess @mwalkerwells @sebinsua @bwestergard
I guess the aforementioned performance hiccup could be discussed in a separate issue?