Exit status isn't failing build using command from docs

[flow]

Exit status isn't failing build using command from docs

[jeffmo]

The main reason we recommend using this bash conditional is because npm scripts throw up a big long error message after the output of the command with lots of detail that isn't relevant. When a command exits successfully though, npm still emits the command's output -- and Flow's output already makes it pretty clear that there's an error.

If you need the exit code of your npm script to be non-zero, there's nothing wrong with removing the conditional and just running flow directly -- you'll just get a little more npm output with each Flow error than you would otherwise :)

[jeffmo]

I made an assumption above too that maybe I shouldn't have: flow exits with status 2 if there is a typechecking error (and any other non-0 code if there is an issue with Flow itself)

[mockdeep]

Ah, good to know. We've gotten in the habit of running npm scripts with -s, so we'll remove the extra check.