Comments (18)
@blacktrash says: The solution is in the button docs: specify display: "none" in the captionTarget content plugin config. Captions will only show after clicking the captions button.
Like
me: Thanks!!!
It works fine!
from flash.
Hiding the captionTarget arguably only works around a bug: It does what it says: it hides the captions, but does not disable them. The indication is that the CC widget still shows them as enabled.
We can decide that disabling captions is not on offer except for embedded captions (and then not dynamically). But then we should make this official.
from flash.
Yes I believe disabling the cuepoint listener when turning off then binding the listener again is an easy solution here. It may cause other issues in the process but would have to find them as it goes. It may be an idea to change the cc button to a dock button in the process if things are going to be changed.
from flash.
Did you want me to go ahead with this ?
from flash.
This is trivial to fix let me know if you want it done thanks.
from flash.
Would this disable user-configured cuepoints too?
from flash.
The requirement is to unbind the cuepoints listener so its not updating anything and then when activated bind the cuepoints listener again and it will start displaying the text again. It might be an idea to change the CC button to a dock button while we're at it as has been requested for a few years now. What do you think.
from flash.
The listener on the plugin that is cuepoints is still functioning as always it might be too much work, to clear out the subtitles cuepoints, or reload on demand might be too slow anyway. So cuepoints would still be dispatching in the player, is that where you want them disabled ?
from flash.
Another option would be to store the loaded cuepoints. when disabling remove them from the players cuepoints, and when enabling add them back in. They get added for each playlist item on startup so would have to be updated for each playlist item at once. A bit of work there. the simplest is to just unbind the event on the plugin.
from flash.
I think it's dangerous to fiddle with the already brittle cuepoints.
My proposal is to address this merely from the UI perspective: Think not "disable", but "hide".
- Leave the documented mechanism in place that to hide subtitles, one has to hide the captionTarget plugin.
- Allow the CC widget to be hidden/revealed by
$f().getPlugin("captions").hide()
and friends; also allowdisplay: none
in config. In other words make the plugin behave like the docs say that all plugins behave. If this is too complicated, move the CC widget to the dock.
This seems like the least invasive change, while being most flexible at the same time.
from flash.
Ok i must of missed something because thats all the button does right now, hides / shows the content plugin. no worries then.
from flash.
what is the purpose of hiding the button sorry ?
from flash.
To disable captions from the user perspective. E.g. start with a hidden captionTarget and offer a scripted/dynamic way to enable captions. When the button is visible user can just click on it.
from flash.
captiontarget: { display: "none" }, would cover hiding the content plugin. dock: true / false should cover configuring to enable a dock button or not (may aswell make it a proper dock button while we are at it ?? ) , external methods showCaptions / hideCaptions() should cover that. According to what I get from that info is what you need. However also configurable via js ie $f().getPlugin("captiontarget").toggle(); will toggle the display.
from flash.
what is the resolution for this ?
from flash.
There's now external methods showButton() and hideButton() in the version currently in our dev site. These methods can be used to show and hide the CC button.
from flash.
Works.
But why new methods, and not the already advertised (for all plugins) hide()
and show()
?
Plugin special case because css()
and animate()
will never work?
I'm asking because it has to be documented.
from flash.
I cannot make those generic functions work here easily, that's why special methods. I know this is not ideal.
from flash.
Related Issues (20)
- Support multi-channel of audio HOT 7
- Flowplayer logs HOT 3
- Incorrect byte range request
- js controls: do not work on iPad HOT 8
- LiveRail Plugins SWF doesnt works with HTTPS HOT 1
- Is there a way to configure options globally in a page? HOT 1
- Switching a playback in midstream shows only a black screen (audio works) HOT 10
- playhead does not move with controlbar autoHide unset HOT 1
- RTMP: onBeforeFinish fired twice
- Error: Call to a possibly undefined method UpButton
- Pause event fired on video finish
- allow exceptions for external plugins
- Live audio doesnt play in IE10
- Flowplayer Flash: Corner case issue with playback of short videos
- Upgrade Google Analytics Classic to Universal HOT 8
- A bug in "get playerBaseUrl" or a bug in "getDomainEnd" ?
- Flowplayer bypasses Adobe Flash Media server protection HOT 1
- How can I use class instead of ID? I have more than one HOT 8
- i want to use httpstreaming
- Javascript API throws "invalid exception" during RTMP livestream
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flash.