[BUG] Color::from_rgbi should not map RGB values to indexes

[vstojkovic]

[BUG] Color::from_rgbi should not map RGB values to indexes

[MoAlyousef]

Thank you for the report and the bisect.
I'll try to look closely at this tomorrow.

[MoAlyousef]

It’s a difficult issue as you said. I’ve reverted the from_rgbi method to as it was, b1406c3. And added a check for the to_rgb method which should work with fltk’s color map. This should also address #1511

I think the only outlier will be Color::TransparentBg since it doesn’t map into the colormap, but it’s already a special value for the Terminal widget and is thus documented as so.

[vstojkovic]

The removal of the mapping logic solves this issue. The check solves #1511, but if some other user has code that relies on the assumption that Color::from_rgbi(0).to_rgb() == (0, 0, 0) this change will break it. Let's hope that's not the case :)

Thank you for working on this!