SQLite: Support binary GUIDs

[lrobin136]

SQLite: Support binary GUIDs

[lrobin136]

Would you be interested if we submitted a PR to support binary guids with SQLite?

[jzabroski]

Hi @lrobin136 . Thanks for your patience. Yes, absolutely. 4.0.0 branch is basically in the bag, we could ship it as 4.1.0 feature.

[jzabroski]

@lrobin136 As this depends on the caller to know the convention set by the connection string, I will implement this as:

        public bool BinaryGuid { get; set; } = false;

        /// <inheritdoc />
        public override string FormatGuid(Guid value)
        {
            if (BinaryGuid)
                return "x'" + value.ToString("N", CultureInfo.InvariantCulture) + "'";
            return base.FormatGuid(value);
        }

Let me know if you disagree with this approach. I would still appreciate the PR, so that (a) you get credit (b) the tests are maintained accordingly. (c) an active SQLite user regression tests this.

[lrobin136]

Hi @jzabroski, Thanks for your feedback. The approach sounds good with me. We'll try to submit a PR in the next few weeks.

[lrobin136]

Hi @jzabroski, we submitted a minimal PR to inject the quoter into the SQLiteColumn. This change solves our initial issue as well, because a user can inject a user-specific quoter for SQLite, that is used in the column as well.

[jzabroski]

I commented on the PR. It solves your initial issue for your team, but does not solve it for this project. I can't accept the PR in this state, as it clearly does not address this issue.