Comments (6)
Saver should be the following patch.
vhs_AbstractContentViewHelper.patch
from vhs.
This problem does not exist in dev-development
and version 7.0+, see https://github.com/FluidTYPO3/vhs/blob/development/Classes/ViewHelpers/Content/AbstractContentViewHelper.php#L236. No further releases will be made in the 6.x branches so I suggest you upgrade VHS to the latest major version 7.0+ (which is compatible with your PHP and TYPO3 versions).
from vhs.
The PHP-code in that place of the patch will cause an error. I added a screenshot from a sandbox for causing the same warning, which caused the exception in my case.
PHP has changed its behavior in the newer versions. The error would caused in version 7.0 in the same way; or can you guarantee, that the value $GLOBALS['TSFE']->recordRegister[$parent]
is defined everytime?
from vhs.
Look at the link I posted. There's an added isset()
check (which does not throw the warning if the index doesn't exist) and if the variable doesn't exist, we initialize it with a value of 1
. If it does exist, we increment it same as before. So yes, the variable is guaranteed to be defined.
The variable is then decremented later without a corresponding isset()
check because at that point, the variable is guaranteed to exist.
from vhs.
Sorry. My Mistake. I havn't read your comment deeply and the code of the develop deeply enough. I am really sorry.
from vhs.
All good @Padina14 :)
from vhs.
Related Issues (20)
- BUG: v:render.request causes error 'Cannot instantiate interface ConfigurationManagerInterface'
- BUG: v:page.menu.directory problem HOT 1
- TYPO3 10.4 throws TypeError
- v:content.render influences action uri generation HOT 2
- BUG: compatibility issue with TYPO3 12.4.7
- BUG: Image Srcset wrong url encoding HOT 1
- (Possible) BUG: with media.image when NO "format" argument is given
- BUG: Breaking change for flagSrc and unexpected value (LanguageMenu)
- DEPRECATION in TYPO3v12: SiteLanguage->getTwoLetterIsoCode()
- BUG: When VHS is installed using redirect in controller does not work without extensionName argument HOT 11
- BUG: Wrong order of middleware registration, HTML gets cut off when including assets HOT 5
- BUG: Exceptions when using UncacheViewHelper on TYPO3 12 HOT 10
- f:format.replace does not work if used in inline syntax
- BUG: MenuViewHelper will not translate one single page - v 7.0.1
- BUG: View helper result only available in child tags since 7.0.0 HOT 4
- TYPO3 13 compatibility HOT 2
- BUG: no request object in v:render.template
- was "classHasSubpages" removed from v:menu on version 7.* HOT 1
- vhs 6.1.3 v:content.render slide not working HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vhs.