Giter Site home page Giter Site logo

Comments (5)

jddeep avatar jddeep commented on May 20, 2024

This has been an issue for the iOS version of VeggieSeasons app as well. There is already an issue open about that #322. @RedBrogdon should we toggle the app font/text colors with respect to the app theme brightness(light or dark).

from samples.

RedBrogdon avatar RedBrogdon commented on May 20, 2024

Thanks for filing an issue, @abd99. There are a few things that should happen here:

  1. Audit all the apps in the repo to make sure there aren't any others with dark mode problems, and file issues for them.
  2. Hard-code a bright theme for any that do, this app included. See #340 for how this was done for Veggieseasons.
  3. Update each of those apps to properly respect dark mode.

That third task is the hardest, and for each app it should be done in several PRs rather than just one big one. It's too large a change to review otherwise.

from samples.

abd99 avatar abd99 commented on May 20, 2024

As per your suggestion @RedBrogdon, I have checked all the apps in the repo except for web and experimental apps for dark mode problems. As of now, none of the apps have that problem except for VeggieSeasons(which you solved temporarily). Most of them don't even support dark mode. Let me know if you want me to add dark mode support to any of them. I have started working on the fix for VeggieSeasons and have shared the solution I'm opting for in #322. Please let me know what you think of it.

from samples.

RedBrogdon avatar RedBrogdon commented on May 20, 2024

@abd99, is there any remaining short-term work for VeggieSeasons now that #322 is merged? I believe we can go ahead and close this if not.

from samples.

abd99 avatar abd99 commented on May 20, 2024

Sure, I think we are good for now with this issue. I'll close it.

from samples.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.