Comments (5)
This has been an issue for the iOS version of VeggieSeasons app as well. There is already an issue open about that #322. @RedBrogdon should we toggle the app font/text colors with respect to the app theme brightness(light or dark).
from samples.
Thanks for filing an issue, @abd99. There are a few things that should happen here:
- Audit all the apps in the repo to make sure there aren't any others with dark mode problems, and file issues for them.
- Hard-code a bright theme for any that do, this app included. See #340 for how this was done for Veggieseasons.
- Update each of those apps to properly respect dark mode.
That third task is the hardest, and for each app it should be done in several PRs rather than just one big one. It's too large a change to review otherwise.
from samples.
As per your suggestion @RedBrogdon, I have checked all the apps in the repo except for web and experimental apps for dark mode problems. As of now, none of the apps have that problem except for VeggieSeasons(which you solved temporarily). Most of them don't even support dark mode. Let me know if you want me to add dark mode support to any of them. I have started working on the fix for VeggieSeasons and have shared the solution I'm opting for in #322. Please let me know what you think of it.
from samples.
@abd99, is there any remaining short-term work for VeggieSeasons now that #322 is merged? I believe we can go ahead and close this if not.
from samples.
Sure, I think we are good for now with this issue. I'll close it.
from samples.
Related Issues (20)
- Update `simplistic_editor` for Flutter 3.13 HOT 1
- [Pedometer] Broken hyper link in README
- The `platform_channels` sample is broken on iOS HOT 1
- `google_maps` Add info window to sample
- Enabled Firebase, lots of Warnings and Unable to upload dSYM HOT 2
- `material_3_demo` dummy question HOT 1
- [State Restoration in iOS] State Restoration in iOS does not work in veggieseasons HOT 2
- Nana2509/up-for-grabs.net
- Remove `src` directory for apps HOT 4
- Web-specific issues with "Material 3 - Flutter WasmGC Preview" HOT 10
- Fix `go_router` builder issue in `navigation_and_routing` sample HOT 1
- Sample `experimental/context_menus` failing on Flutter 3.16beta and above HOT 3
- `jsonexample` failing on Flutter 3.16 beta HOT 1
- Fill in `onSearchWeb` and `onShare` for `simplistic_editor`
- github.io playback HOT 2
- `experimental/context_menus`: Test failing on Flutter 3.18.0-7.0.pre.57 HOT 2
- build fail in github action for game template
- Identify M3 demo sample issues, determine source of each, and file relevant issues HOT 2
- Decide what to do with Flutter Gallery sample
- Remove experimental/material_3_demo HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from samples.