Comments (12)
Yes that might have missed out but maybe in next release we can accommodate for string as room id. Although if you want you can open a pr and i would gladly accept it since i am bit busy these days
from flutter_janus_client.
I'll see what I can do. I rather help improving this plugin, than creating one on my own.
from flutter_janus_client.
Should not have been closed. roomId should be of type dynamic.
string_ids == false: Janus expects int, and returns int for publisherId
string_ids == true: Janus expects string, and returns string for publisherId
I will run my code again, and provide a list of places where updates are required.
from flutter_janus_client.
ahh i see fixing it right away
from flutter_janus_client.
Also update events and other object
interfaces/video_room/events/video_room_event
int room
-> dyamic room
map['room'] as int,
-> map['room'],
I'm checking the received id's for publishers.
from flutter_janus_client.
@UserSense you can verify now should work fine across all major plugins
from flutter_janus_client.
I will do a check for videoRoom with string_ids == true.
from flutter_janus_client.
At the moment I found the following in VideoRoom:
interfacese/video_room/video_room/events/video_room_event.dart
copyWith
int? room,
-> dynamic room
,
VideoRoomEvent.fromMap
map['room'] as int,
-> map['room']
,
interfacese/video_room/video_room/events/video_room_joined_event.dart
int? id;
-> dynamic id;
in VideoRoomJoinedEvent
int? id;
-> dynamic id;
in Publishers
Example response when joining, both room and id are strings in this case.
{videoroom: joined, room: 198, description: Room 198, id: e7f8e202-61ca-4b7e-bec0-828610f1e917, private_id: 348602811, publishers: [], attendees: []}
interfacese/video_room/video_room/events/video_room_list_participants.dart
int? id;
-> dynamic id;
in Participants
Additional tests are required
from flutter_janus_client.
hi, the issue does not seem to have been fixed, especially in videoroom plugin
from flutter_janus_client.
now check made some fixes
from flutter_janus_client.
now check made some fixes
seems to work, thanks for the quick response :)
I noticed that _getPluginDataFromPayload does not use the fromJson and returns the raw map
from flutter_janus_client.
Closing then, let me know if you see any discrepancies related to this change or the issue in general
from flutter_janus_client.
Related Issues (20)
- if network refresh/reset/reconnect then how to reconnect janus videoroom publisher and subscriber again? HOT 1
- hard decoding HOT 3
- Failing to build for web HOT 4
- Problem with microphone HOT 2
- In Android call directly run on a Speaker mode. HOT 1
- Bump http version to 1.0.0 HOT 2
- android exception HOT 10
- How to check session's status in text room plugin HOT 2
- Switch audio Route HOT 2
- Re-joining a call not working for videoroom plugin HOT 15
- Can't mute or use speaker HOT 7
- Audio Output on IOS HOT 2
- RTCVideoRenderer Video rendering and steaming issue HOT 3
- Cannot capture screen whith no media devices HOT 3
- isUnifiedPlan = true is not working HOT 7
- Error When try to create an answer HOT 16
- IOS device not publishing their own video in video room HOT 11
- [Linux] Error when disposing VideoRoomPlugin HOT 2
- join google meet only as audience not publishing anything HOT 9
- Cant use RTCIceServer without credential/password HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flutter_janus_client.