VideoRoom: RoomId wrong type

[flutterjanus]

VideoRoom: RoomId wrong type

[shivanshtalwar0]

Yes that might have missed out but maybe in next release we can accommodate for string as room id. Although if you want you can open a pr and i would gladly accept it since i am bit busy these days

[UserSense]

I'll see what I can do. I rather help improving this plugin, than creating one on my own.

[UserSense]

Should not have been closed. roomId should be of type dynamic.

string_ids == false: Janus expects int, and returns int for publisherId
string_ids == true: Janus expects string, and returns string for publisherId

I will run my code again, and provide a list of places where updates are required.

[shivanshtalwar0]

ahh i see fixing it right away

[UserSense]

Also update events and other object

interfaces/video_room/events/video_room_event

int room -> dyamic room
map['room'] as int, -> map['room'],

I'm checking the received id's for publishers.

[shivanshtalwar0]

@UserSense you can verify now should work fine across all major plugins

[UserSense]

I will do a check for videoRoom with string_ids == true.

[UserSense]

At the moment I found the following in VideoRoom:

interfacese/video_room/video_room/events/video_room_event.dart

copyWith

int? room, -> dynamic room,

VideoRoomEvent.fromMap

map['room'] as int, -> map['room'],

interfacese/video_room/video_room/events/video_room_joined_event.dart

int? id; -> dynamic id; in VideoRoomJoinedEvent
int? id; -> dynamic id; in Publishers

Example response when joining, both room and id are strings in this case.

{videoroom: joined, room: 198, description: Room 198, id: e7f8e202-61ca-4b7e-bec0-828610f1e917, private_id: 348602811, publishers: [], attendees: []}

interfacese/video_room/video_room/events/video_room_list_participants.dart

int? id; -> dynamic id; in Participants

Additional tests are required

[MrNB0dy]

hi, the issue does not seem to have been fixed, especially in videoroom plugin

[shivanshtalwar0]

now check made some fixes

[MrNB0dy]

now check made some fixes

seems to work, thanks for the quick response :)

I noticed that _getPluginDataFromPayload does not use the fromJson and returns the raw map

[shivanshtalwar0]

Closing then, let me know if you see any discrepancies related to this change or the issue in general