Should open Windows Terminal if not already started

[flyingpie]

Should open Windows Terminal if not already started

[justinledwards]

This issue is actually because of how microsoft is doing application aliases. To run the newer version of windows terminal I had to disable the old one launched via the alias. The exe itself is 0 bytes if you look.

[flyingpie]

Hello @vertti, thank you for reporting this issue! This should actually already happen, could you provide the warning to see why wtq is not starting wt?

[vertti]

That is what pops up when starting the quake 1.1.1 when I do not have Windows Terminal running. If I start Windows Terminal my self and after that the quake, everything works.

[flyingpie]

@vertti That's weird, what happens if you enter "wt" on the command line?

[flyingpie]

Also, I think this might be the same issue as reported here: #61. Fellow fmiqbal points out that repairing the Windows Terminal installation fixed the issue. He also wasn't able to run "wt" separately, so I'd like to know whether that does work on your machine.

[vertti]

Running C:\Users\vertti\AppData\Local\Microsoft\WindowsApps\wt.exe from command line works. I also tried running the Settings -> Apps -> Windows Terminal -> Repair. Still get the error from quake if Windows Terminal is not already running.

[flyingpie]

@vertti I've uploaded a new release with a new setting called "WindowsTerminalCommand", which controls the actual command that is used to start Windows Terminal, if it isn't running already.

Could you try to run this version with a setting such as:

{
	"WindowsTerminalCommand": "C:\\Users\\vertti\\AppData\\Local\\Microsoft\\WindowsApps\\wt.exe"
}

I'm not sure why the app isn't finding wt.exe (which is the default command), but perhaps we can find something by messing around with the command.

It's release 'windows-terminal-quake-1.2.0-2021-04-30_1752.zip' here:

https://github.com/flyingpie/windows-terminal-quake/releases/tag/v1.2.0

[juventus18]

sounds like you need to put windows terminal folder into your PATH env variable

[flyingpie]

@juventus18 True, but as far as I know, shouldn't that be done by the Windows Terminal installation?

[vertti]

@flyingpie thanks, works great!

At least for me, installing WT from Microsoft Store, it does not add it to the PATH.

[untoreh]

can this be extended to allow terminals other than Windows Terminal?

[flyingpie]

@untoreh It should, which one are you wanting to use?

[untoreh]

@flyingpie wezterm

[flyingpie]

@untoreh There is currently some Windows Terminal-specific stuff going on, but I don't see too much of a problem adding support for this.

Though, it's a little off-topic for this issue, could you open a new one with that specific feature request?

[flyingpie]

@justinledwards Thank you so much for reporting this! Saved us a ton of time :D I'll add this to the docs.