Make it possible to add resources with `classpath:` prefix

[flyingsaucerproject]

Make it possible to add resources with `classpath:` prefix

[andrzej-talarek]

Confirmed, works perfectly again :-). Great thanks @asolntsev !

[asolntsev]

@lowcasz Did it ever work? Do you mean that FlyingSaucer did load resources from classpath, and this feature was broken with some release? Or it never really worked, and you just wish such a feature?

[lowcasz]

It was worked on my other project.
HTML is copied from old project for test, it was work there.
I don't see any other configuration and configuration classes between them.
In old project is older version of saucer. (9.1.22)

[pbrant]

Some frameworks will supply a classpath:// URL handler. See e.g. https://stackoverflow.com/questions/861500/url-to-load-resources-from-the-classpath-in-java. We've done something similar internally before. Could that be why it worked before? I don't think this is something that FS has supplied out of the box though.

…

On Fri, Oct 6, 2023 at 1:13 PM Cezary Hadrzyński ***@***.***> wrote: It was worked on my other project. — Reply to this email directly, view it on GitHub <#216 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAF42FAAXLXT4DB3WVO7S3X57RWZAVCNFSM6AAAAAA5U3E442VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJQGQZTMMJRGM> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[lowcasz]

I don't know, maybe...
Do you know any dependency, especially spring dependency which can do it in background?
It can helps me to find it, I don't see any additional parameters, configuration or classes which do it.

[pbrant]

I do not, I'm afraid.

…

On Fri, Oct 6, 2023 at 1:28 PM Cezary Hadrzyński ***@***.***> wrote: I don't know, maybe... Do you know any dependency, especially spring dependency which can do it in background? It can helps me to find it, I don't see any additional parameters, configuration or classes which do it. — Reply to this email directly, view it on GitHub <#216 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAF42EOC7HEPBEXOGL4NODX57TMZAVCNFSM6AAAAAA5U3E442VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJQGQ3DQOJZG4> . You are receiving this because you commented.Message ID: ***@***.***>

[asolntsev]

@lowcasz implemented in #241, released version 9.3.2 today.

[andrzej-talarek]

Funny thing, but in my case it worked perfectly fine (classpath:/static/css/custom.css) in 9.3.1 version and broke with 9.3.2 :(. It's broken both for bootJar task, that I'm using for system development usually and normal building jar for running it with java -jar. Can't upgrade.

2023-12-31 06:18:15.880 ERROR -  o.a.j.l.DirectJDKLog : Servlet.service() for servlet [dispatcherServlet] in context with path [] threw exception [Request processing failed: java.lang.NullPointerException: Cannot invoke "java.net.URL.toString()" because "resource" is null] with root cause
java.lang.NullPointerException: Cannot invoke "java.net.URL.toString()" because "resource" is null
	at org.xhtmlrenderer.swing.NaiveUserAgent.resolveURI(NaiveUserAgent.java:370)
	at org.xhtmlrenderer.context.StyleReference.getStylesheets(StyleReference.java:224)
	at org.xhtmlrenderer.context.StyleReference.setDocumentContext(StyleReference.java:85)
	at org.xhtmlrenderer.pdf.ITextRenderer.setDocument(ITextRenderer.java:183)
	at org.xhtmlrenderer.pdf.ITextRenderer.setDocument(ITextRenderer.java:144)
	at org.xhtmlrenderer.pdf.ITextRenderer.setDocumentFromString(ITextRenderer.java:167)
	at org.xhtmlrenderer.pdf.ITextRenderer.setDocumentFromString(ITextRenderer.java:160)

[asolntsev]

@andrzej-talarek Thank you for the feedback.
First of all, I assume that FS 9.3.1 didn't really load custom.css file, but just silently ignored it.
And FS 9.3.2 started searching this file in classpath and complaining if the file cannot be found.

Are you sure you have folder static in the classpath?

If yes, how can I reproduce the problem? Could you create a simple reproducible example?

[andrzej-talarek]

I'm 100% sure it worked fine - I've used several included styles (custom ones and bootstrap styles) and I know styles worked OK then (looking at final pdf).
Since it's spring-boot app, I'm not sure it would be that easy, but I can try to prepare a repo with as little code as it only requires.

[pbrant]

@andrzej-talarek This should be fixed in #250.

[asolntsev]

@andrzej-talarek The fix #250 has been released as FlyingSaucer 9.4.1
Can you please check if it helps?