Comments (7)
Forget my point b) again. Overlooked the definition.
The vendor name should still be changed though.
But why do you need this?
require_once(ExtensionManagementUtility::extPath('generic_gallery').'Classes/Domain/Model/Dto/EmConfiguration.php');
from generic-gallery.
Another question: why do you exclude PHP 7.1?
from generic-gallery.
Hey there!
use TYPO3 as vendor in the namespace
Afaik only TYPO3\CMS
is reserved but I know the current NS is not optimal. I plan to move ALL my extensions to a custom vendor NS but still undecided which one ;-)
But why do you need this?
require_once(ExtensionManagementUtility::extPath('generic_gallery').'Classes/Domain/Model/Dto/EmConfiguration.php');
Changed this lately (see 9abd1ff) as GeneralUtility::requireOnce
has been deprecated. To be honest, I took the idea from this straight from EXT:news and it seems it's changed there too.
why do you exclude PHP 7.1?
Only because it's untested and I don't like to say its ready if I'm not sure about it. Are you able to confirm everything works fine?
from generic-gallery.
Vendor= FNAGEL?
Changed this lately (see 9abd1ff) as GeneralUtility::requireOnce has been deprecated. To be honest, I took the idea from this straight from EXT:news and it seems it's changed there too.
Why do you need to require the file at all? We have autoloading in place, so it will find the file anyways.
I didn't test with PHP7.1 but there is really low chance that something really breaks with it, since there are no real breaking changes.
from generic-gallery.
Vendor= FNAGEL?
or FNA (which might be taken already) or FelixNagel or FelixNagelCom (upper camel case is better, right?). Anyway, I need some time to change this for all my extensions...
Why do you need to require the file at all?
Good question, actually. Doesn't seem to make sense. As said I took this straight from EXT:news: https://github.com/georgringer/news/blob/master/Classes/Utility/EmConfiguration.php#L29
Anyway, seems worth trying to remove it.
I didn't test with PHP7.1 but there is really low chance that something really breaks with it, since there are no real breaking changes.
I don't have any experience with 7.1 yet, so I can't speak from experience but I guess you're right.
from generic-gallery.
FNAGEL or FNA
It simply does not matter. And I doubt that even if it is taken that the extensions will have the same name too. So that's unique enough.
require once in ext:news
I would say this is legacy and a leftover. This thing is in there since at least 2015. We can ask Georg for details.
PHP 7.1
We run live sites on 7.1 without any issues.
(Except if you use ext:yag, which really is not 7.1 compatible)
from generic-gallery.
Closed with b177dcd
from generic-gallery.
Related Issues (20)
- No setup.txt Error HOT 4
- Gallery type not selectable HOT 10
- SQL error: 'Incorrect integer value: '' for column `c1_SQL01`.`tt_content`.`tx_generic_gallery_collection` at row 1' HOT 11
- Desired FileCollection type "images" is not in the list of available FileCollections. HOT 6
- Feature - make existing sys_file_collection selectable HOT 5
- TYPO3 11 support HOT 2
- BE parse error in PHP 7.4 with version 5.0.0 HOT 5
- PHP Warning in PageLayoutViewHook.php HOT 2
- PHP Warning in AbstractController.php HOT 3
- PHP Warning in GalleryCollectionController.php HOT 2
- PHP Warning in TcaHook.php HOT 2
- 4.3: Template not loaded despite overridden template path HOT 3
- SQL error: 'Incorrect integer value: '' for column `typo3srh`.`tt_content`.`tx_generic_gallery_collection`
- Installation Generic_Gallery Typo3 11.5.22 php 8.0 HOT 7
- Size of zoom image HOT 5
- TYPO3 12 support HOT 2
- Error 503 : ...GalleryItem::getImageReference(): Return value must be of type ...FileReference, null returned HOT 3
- The TYPO3 extension package "felixnagel/generic-gallery", does not define an extension key in its composer.json HOT 3
- Extension throws exception if no image title was set HOT 1
- Bootstrap 5 carousel examples do not start sliding automatically HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from generic-gallery.