Serializer validation function for GPU limit executed implicitly

[fnndsc]

Serializer validation function for GPU limit executed implicitly

[Chris210634]

@ravisantoshgudimetla @jbernal0019,

Here's what I think is happening, before perform_create() is called in views.py, serializer.is_valid() is called. is_valid() looks through the methods of PluginInstanceSerializer and looks for methods named validate_<field name>. is_valid() automatically executes these methods. The reason validate_gpu_limit() is called implicitly and not validate_previous is because the field for previous instance ID is named previous_id, not previous.

Two potential solutions are:

1. rename the functions (easiest way)
2. remove "plugin" argument from validate_<> function definitions and execute as the first line in validation functions:

plugin = self.context['view'].get_object()

Django's documentation suggests this as well:

Field-level validation

You can specify custom field-level validation by adding .validate_<field_name> methods to your Serializer subclass. These are similar to the .clean_<field_name> methods on Django forms.

These methods take a single argument, which is the field value that requires validation.

Your validate_<field_name> methods should return the validated value or raise a serializers.ValidationError. For example:

[http://www.django-rest-framework.org/api-guide/serializers/]

[jbernal0019]

That makes sense @Chris210634 @ravisantoshgudimetla. Good catch!

Please modify accordingly