Improvement to API load tests

[michthom]

Improvement to API load tests

[fnuecke]

I haven't played around with Lua in resource packs, so I have no idea, but what you say sounds logical to me. A simpler adjustment might be

assert(os.loadAPI("apis/startup") or os.loadAPI("/rom/apis/startup"))

My reasoning for trying the old way first is to still allow overwriting whatever is provided via resource packs.
Could you test this to see if it works?

[michthom]

Ah - good points, and yes I'll test this and let you know.

Sadly there doesn't seem to be a way to suppress the 'file not found' message to the console from loadAPI.
I was hoping for a "command > /dev/null" equivalent but haven't found one yet.
Using 'protected mode' didn't help either e.g.

local state, value = pcall ( os.loadAPI, "apis/startup")
if ( state ) then ... else ... end

Happy New Year by the way!

On 1 Jan 2014, at 03:56, Florian Nücke [email protected] wrote:

I haven't played around with Lua in resource packs, so I have no idea, but what you say sounds logical to me. A simpler adjustment might be

assert(os.loadAPI("apis/startup") or os.loadAPI("/rom/apis/startup"))
My reasoning for trying the old way first is to still allow overwriting whatever is provided via resource packs.
Could you test this to see if it works?

—
Reply to this email directly or view it on GitHub.

[fnuecke]

Ah, right, that. I remember I was also annoyed by that just printing to the screen when it (I feel) shouldn't. An fs.exists check may be necessary or something along those lines...

And a happy new year to you, too!

[michthom]

Hi Florian

I think I’ve fixed the issue, with minimal code changes, once I’ve tested properly I’ll send you a diff to look at?
Or should I fork / commit / send you a pull request in github?

The bios was loading the lama API on a freshly-created turtle, and the check in the main code path through the API for os.computerLabel() was failing the assert(). That led to the blank screen in the CC console as the bios doesn’t seem to like assert failures in os.loadAPI().

I moved all the main code path asserts into the init() code path, after the check for isInitialized, so they only get run once.

I’ve left the original apiPath definition alone, but added a manual search for valid locations if bapil is not available.

Sticking the lama API in /rom/apis/turtle/lama then hides it from computers, and I think it’s good to go.

Thanks for your help and gentle suggestions (which caused me to face palm myself for stupidity!)

Cheers
Mike

On 1 Jan 2014, at 14:36, Florian Nücke [email protected] wrote:

Ah, right, that. I remember I was also annoyed by that just printing to the screen when it (I feel) shouldn't. An fs.exists check may be necessary or something along those lines...

—
Reply to this email directly or view it on GitHub.

[fnuecke]

Sounds good! A pull request would be the easiest for me, but you can make it a patch, if you prefer.