Giter Site home page Giter Site logo

Comments (2)

geemus avatar geemus commented on August 20, 2024

I must admit I don't personally have much experience with the assume role and web identity stuff, but that sounds reasonable to me.

I do also wonder why it does that request in such a raw/direct way in the credential fetcher vs calling the assume_role_with_web_identity method. It might also be nice to get rid of that duplication if possible.

I'm open to this change and pull request, so just let me know if you have other questions or need support.

from fog-aws.

marshluca avatar marshluca commented on August 20, 2024

@geemus thank you for your kind response.

The reason to use the raw way is simply because it's simpler to code like this.

ENV["AWS_WEB_IDENTITY_TOKEN_FILE"] = 'YOUR_AWS_WEB_IDENTITY_TOKEN_FILE_PATH'
s3 = Fog::AWS::Storage.new(
      region: 'ap-southeast-1',
      use_iam_profile: true,
      role_arn: 'YOUR_AWS_ROLE_ARN'
)

For the current version, It would be appreciated if it could be aligned.
I am happy to see to get rid of the duplication in the future :)

from fog-aws.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.