Key bindings are broken with a dvorak keyboard

[webhat]

Key bindings are broken with a dvorak keyboard

[Aaron1011]

@webhat: Can you elaborate on what problem you're experiencing?

[webhat]

Sure, as you might know the mapping for the dvorak keyboard is different, as shown below, the keys ,AOQ are mapped to WASD positions on the keyboard rather than being mapped to the characters. BTW I'm on OSX.

[fogleman]

You can change the key controls in config.h

[dykatz]

Should we add a file so that we do not have to recompile every time we want to change settings?

[commonquail]

@muddmaker: I already have that working. I hope to polish up and push later today.

[webhat]

@commonquail I don't think this would solve it, unless it's mapping the characters not the keys.

[commonquail]

@webhat: I'm addressing a slightly different concern (#64) but you're right, it won't solve your problem (I've just confirmed). We can't tell GLFW to consider the user's keyboard locale so it consistently generates the same scan- and key codes, but with different keyboard layouts those codes are virtually worthless. GLFW has an open issue about it. I don't really know what to do about it but, in the meantime, if I don't change the bindings (i.e. retain WASD movement) and switch to Dvorak I can still move around.

[Edit] Well, it occurs to me we could make configuration take the key codes instead of the characters. I haven't tried it but that might actually completely solve the problem. That introduces the problem of users identifying key codes, however, and I almost think that's a bigger issue. The main argument for would be that key codes are unambiguous so even if you can't relate to them they work predictably, whereas in some cases, such as this one, the increased transparency of understandable values behaves unpredictably.

[webhat]

After a little looking around I see there is a fix which has been posted to resolve glfw/glfw#114, dougbinks/glfw@5776f9a which maps the keycodes to the scan codes. It doesn't look like it has been merged yet.

I'll have to try it to confirm.

[weslly]

I'm using Colemak and I love the fact that the game uses QWERTY for the controls and Colemak for the chat, this way I don't need the change the key bindings to match the WASD movement keys but I can type with Colemak in the chat. IMHO, I consider it more like a feature than a bug.

[bahamas10]

+1 feature not a bug. i like QWERTY controls with dvorak chat.

[fogleman]

What they said.

[webhat]

As this will be fixed in https://github.com/glfw/glfw/issues?milestone=2 I tend to agree that this is not a bug in Craft. Thanks.