Giter Site home page Giter Site logo

Comments (4)

stefan6419846 avatar stefan6419846 commented on June 3, 2024 1

Thanks for the PR. I had a quick look at it and now I am able to at least get some hints regarding the third-party licenses.

from fomantic-ui.

lubber-de avatar lubber-de commented on June 3, 2024

TLDR;
Please provide ideas / PRs where to improve the asset documentation as i think, license-wise, we already did what is necessary.

Lato 2.0 was bundled by #2359 from https://www.latofonts.com/lato-free-fonts/ (not google, which only provide lato 1.0)

According to https://openfontlicense.org/ and https://openfontlicense.org/how-to-use-ofl-fonts/ the OFL-1.1 does not need any separate attribution as we are bundling the font in an open source package

Fomantic UI bundles the whole unmodified fontawesome icon font files. The create-fomantic-icons script is used to create the related css classes and the docs page. The script does not create the woff files themselves.
As stated at https://fontawesome.com/license/free#attribution the original files already contain the sufficient attribution

I quickly checked the bundled files via fontforge and yes, the attribution information is still inside those untouched files

Lato:
image

Fontawesome
image

On the docs page, it is basically mentioned where the origin of the font files is.
I have to admit, at least for Lato 2.0, this could be improved

https://fomantic-ui.com/usage/theming.html#progressive-truthfulness
The "Lato" Text links to the original font website
image

I think for FontAweseome it's all fine mentioned at https://fomantic-ui.com/elements/icon.html
image

So, if you got some ideas where to improve either Code or docs, feel free to tell us or provide a PR to help Fomantic UI getting better 🙂

from fomantic-ui.

stefan6419846 avatar stefan6419846 commented on June 3, 2024

Thanks for the explanations. I have to admit that I did not read through the whole documentation outside of the GitHub repository as I usually prefer some centralized licensing explanations.

As some background: In the third-party project at django-cms/djangocms-frontend#167, I stumbled upon the fact that the project license is MIT, but djangocms-frontend bundling only the font files which are subject to the OFL-1.1 instead (due to originating from FontAwesome and the file-based copyleft effect). This is not obvious from the root-level license file.

Please note that I am not a Javascript frontend developer, but rather coming from the Python landscape. I am aware that everyone considers different approaches, but I generally prefer to either have license files in all third-party directories or a secondary license file at the root level which documents all third-party components to simplify license reviews.

from fomantic-ui.

lubber-de avatar lubber-de commented on June 3, 2024

I added the license files where appropriate by #2959

from fomantic-ui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.