Giter Site home page Giter Site logo

Comments (5)

divmain avatar divmain commented on May 22, 2024

You're the first person to pull this down and give it a try! Let me get back to you tomorrow morning, it has been a couple of late nights to put my thoughts into code.

from rapscallion.

mhaagens avatar mhaagens commented on May 22, 2024

I'm really excited for this library, great work!
I'm using renderToString from rapscallion now and it shaved off roughly ~200ms from my server render, so I'm very excited about getting the streaming working. Whenever you have time to take a look at it that would be awesome :)

from rapscallion.

mhaagens avatar mhaagens commented on May 22, 2024

I'll just post this here as well, when used with React Router renderToString returns;

TypeError: Cannot read property 'createHref' of undefined

in case you're using this with React Router as well and know what's causing this?

from rapscallion.

divmain avatar divmain commented on May 22, 2024

@mhaagens, the stream issue should be fixed and release in 1.0.2. Could you open an issue regarding React Router, possibly with a minimal reproduction? I haven't done too much testing yet, so real-world examples will be hugely useful to me.

Bed now though, for realz this time.

from rapscallion.

mhaagens avatar mhaagens commented on May 22, 2024

Thanks for the super fast fix! I'll open an issue regarding React Router.
And yeah, get some sleep 👍

from rapscallion.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.