Always plays the same radio source

[fossfreedom]

Always plays the same radio source

[fossfreedom]

what version of rhythmbox are you using?

[GuillaumeHM]

3.2.1, on debian Stretch 64 bit.

[fossfreedom]

ok - thanks.

There is a definite bug in rhythmbox where "jump-to-current" suddenly becomes an invalid function for radio-sources.

radio-sources dont seem to register correctly with the plugin. The plugin works ok with standard music tracks.

[GuillaumeHM]

OK, the bug is a bit more complicated.
The plugins registers the last source if the previous one was not a radio.

Play a music file
Play a web radio A
Close RB.
Open RB -> it correctly plays the last source (radio A)
Play Radio B
Close RB
OpenRB -> It wrongly plays Radio A
Play a music file
Play Radio B
Cose RB
Open RB -> It correctly plays Radio B

I think the jump-to-current problem is another issue, do you confirm ?

[fossfreedom]

jump-to-current errors messes with the saving.

But yes - once commented out, this leaves an underlying issue with handling radio-streams.

[fossfreedom]

@GuillaumeHM - think the above commit fixes this. Can you give this a try please?

[GuillaumeHM]

Works perfectly fine, thank you very much ! And I don't have the crash around jump_to_current anymore.

[fossfreedom]

ta for testing.

I've done some small tweaks to get the pause & play/pause on startup options in preferences working correctly.

I'll close this now. Cheers.

[GuillaumeHM]

Play/Pause feature works fine now but I have a small moment when audio is played before being muted at startup.

[fossfreedom]

yep - nothing I can really do about that. Rhythmbox itself doesnt offer a way to mute BEFORE playing - you can only mute AFTER playing.

I could in theory use pulseaudio to turn off the sound but that would mean introducing python3-pulseaudio - its not in current distro's so it will mean making people install this manually. Thus this will dissuade people from installing the plugin.