Giter Site home page Giter Site logo

Comments (9)

GMishx avatar GMishx commented on May 20, 2024

That would be a good change. But will it effect the existing pyproject.toml (compatibility with PEP 518)?

from atarashi.

Kaushl2208 avatar Kaushl2208 commented on May 20, 2024

Yes, It will replace pyproject.toml and it might affect setup.py. Not sure, about it rn.

Can I submit a PR for it?

from atarashi.

GMishx avatar GMishx commented on May 20, 2024

Yes, sure @Kaushl2208. Just make sure the current build wheel build should not break because of this change.

from atarashi.

lohithmunakala avatar lohithmunakala commented on May 20, 2024

Is this still open @GMishx ? I wanna work on this.

from atarashi.

GMishx avatar GMishx commented on May 20, 2024

Yes @lohithmunakala, from my end the issue is still open. @Kaushl2208 do let us know if you are working on the issue.

It will be nice to assign the issue to the person currently working on it.

from atarashi.

lohithmunakala avatar lohithmunakala commented on May 20, 2024

If @Kaushl2208 isn't working on it rn, can you help me get started with the issue @GMishx ?

from atarashi.

Kaushl2208 avatar Kaushl2208 commented on May 20, 2024

Hey @GMishx, We can assign this issue to @lohithmunakala. I don't have the rights to do so.

from atarashi.

hastagAB avatar hastagAB commented on May 20, 2024

Hey @GMishx, We can assign this issue to @lohithmunakala. I don't have the rights to do so.

Meanwhile @lohithmunakala You can start working on this issue. It will be a great help.

from atarashi.

GMishx avatar GMishx commented on May 20, 2024

I have assigned the ticket to you @lohithmunakala .

You can start looking into pipenv documentation: https://pipenv.pypa.io/en/stable/
Expectation from this change is:

  1. Removal of dependencies from requirements.txt and setup.py
  2. Should not break PEP 517 changes (try to build Dockerfile to test)
  3. Clear separation of additional dependencies like csv and json files generated by running python3 setup.py build

from atarashi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.