Comments (9)
That would be a good change. But will it effect the existing pyproject.toml (compatibility with PEP 518)?
from atarashi.
Yes, It will replace pyproject.toml and it might affect setup.py. Not sure, about it rn.
Can I submit a PR for it?
from atarashi.
Yes, sure @Kaushl2208. Just make sure the current build wheel build should not break because of this change.
from atarashi.
Is this still open @GMishx ? I wanna work on this.
from atarashi.
Yes @lohithmunakala, from my end the issue is still open. @Kaushl2208 do let us know if you are working on the issue.
It will be nice to assign the issue to the person currently working on it.
from atarashi.
If @Kaushl2208 isn't working on it rn, can you help me get started with the issue @GMishx ?
from atarashi.
Hey @GMishx, We can assign this issue to @lohithmunakala. I don't have the rights to do so.
from atarashi.
Hey @GMishx, We can assign this issue to @lohithmunakala. I don't have the rights to do so.
Meanwhile @lohithmunakala You can start working on this issue. It will be a great help.
from atarashi.
I have assigned the ticket to you @lohithmunakala .
You can start looking into pipenv documentation: https://pipenv.pypa.io/en/stable/
Expectation from this change is:
- Removal of dependencies from requirements.txt and setup.py
- Should not break PEP 517 changes (try to build Dockerfile to test)
- Clear separation of additional dependencies like
csv
andjson
files generated by runningpython3 setup.py build
from atarashi.
Related Issues (20)
- build dependencies are not getting install properly
- Build fails HOT 14
- Make the code PEP8 compliant HOT 2
- Run the evaluator command without any 'similarity' parameter HOT 2
- Shift from argparse module to plac command line parser. HOT 3
- Parallelize the evaluator algorithm HOT 5
- [Proposal] Improve the speed of matching HOT 1
- Pandas error at run: pandas.errors.ParserError HOT 1
- ModuleNotFoundError occurs when running after installing with pip. HOT 3
- Broken Link in README.md
- Ability to scan directories HOT 22
- Invalid File Path in Atarashi HOT 4
- List Index Out of Range HOT 3
- FEAT: Increasing the overall performance of Atarashi HOT 1
- Removing third party module in dameruLevenDist agent HOT 2
- Build fails due to import error from nirjas HOT 1
- Error in CommentPreprocessor
- Improve TF-IDF agent by tuning matches threshold HOT 1
- Make evaluation.py more informative
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from atarashi.