Giter Site home page Giter Site logo

Comments (5)

hanspr avatar hanspr commented on July 19, 2024

Fixed,

Edit : overlay.js

If hide_on_close is set will check for the number of windows opened.
If more than one, ignores de hide_on_close, will actually close the window.
If is the last opened windows, will hide it.

if (hides_on_close) {
if (firetray.Handler.windowsCount == 1) {
if (hides_single_window) {
let winId = firetray.Handler.getWindowIdFromChromeWindow(win);
firetray.Handler.hideSingleWindow(winId);
} else
firetray.Handler.hideAllWindows();
event && event.preventDefault();
}
}

This works fine for me, but other people might not like it, that is why I believe that there should be an option for this behavior.

Good luck

from firetray.

foudfou avatar foudfou commented on July 19, 2024

Hi, a few suggestions:

  • you can close individual windows using the keyboard (Ctrl-w), although this might not be very handy if you use the mouse a lot
  • you could use the minimize button for actually hiding to tray, and keep the close button for closing windows (unset Closing window hides to tray, set "Minimizing window hides to tray*)

Regarding your request for a new hides_on_close_last_only preference, I'd prefer to wait for similar requests/complaints before actually implementing it.

from firetray.

tomjenkinson avatar tomjenkinson commented on July 19, 2024

I would like to request the capability described in the bug report, I like to use Alt-F4 to close the window until I hit the last window which I like to minimize, a bit like firetray for thunderbird

from firetray.

foudfou avatar foudfou commented on July 19, 2024

Here your are :-) 90ee9f8 You can build it yourself or it will be included in the next soon coming version.

from firetray.

tomjenkinson avatar tomjenkinson commented on July 19, 2024

Thanks! Great stuff :)

On 2012-09-10T14:06:42 BST, foudfou wrote:

Here your are :-) 90ee9f8
90ee9f834b44 You can
build it yourself https://github.com/foudfou/FireTray/wiki/Build or
it will be included in the next soon coming version.


Reply to this email directly or view it on GitHub
#24 (comment).

from firetray.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.