Explicit documentation for `expectRevert` when errors are identical.

[simplyoptimistic]

Explicit documentation for `expectRevert` when errors are identical.

[mds1]

If you have this:

contract A {
  error NotValid();
  // contract A specific code here...
}
contract B {
  error NotValid();
  // contract A specific code here...
}

Then A.NotValid.selector == B.NotValid.selector, where the selector is computed the same as function signatures, i.e. bytes4(keccak256("NotValid()")) == 0xf1640ae1. Therefore you cannot distinguish them by the thrown error alone.

This is a good point though, I'd suggest creating an issue in the foundry repo to add a series of vm.expectRevert overloads that take an address arg, where the address input is the contract you expect to throw the initial revert