feat: check for successful deploy in `deployCode`

[foundry-rs]

feat: check for successful deploy in `deployCode`

[mds1]

Just want to clarify in case anyone picks this up, since the format and example seem to differ a bit. I'd personally suggest:

require(condition, "ContractName (functionName): Error message here.");

In other words, no underscores in the require statements. Alternatively, we could do functionSig (e.g. deal(address,uint256)) instead of functionName (e.g. deal) to help disambiguate overloaded functions.

[ZeroEkkusu]

We can use the same PR to standardize the error messages to be easy to figure out what reverted.

Format:
ContractName_(functionName)__Error_message

Example:

Traces:
  [144] ContractTest::setUp() 
    └─ ← ()

  [123470] ContractTest::testExample() 
    ├─ [0] VM::record() 
    │   └─ ← ()
    ├─ [236] ContractTest::a42c4a23(000000000000000000000000b4c79dab8f259c7aee6e5b2aa729821864227e84) [staticcall]
    │   └─ ← ()
    ├─ [0] VM::accesses(ContractTest: [0xb4c79dab8f259c7aee6e5b2aa729821864227e84]) 
    │   └─ ← [], []
    └─ ← "StdStorage (find)  No storage use detected for target"

Test result: FAILED. 0 passed; 1 failed; finished in 1.09ms

Failed tests:
[FAIL. Reason: StdStorage (find)  No storage use detected for target] testExample() (gas: 123470)

[lonerapier]

Ok, will do that.

[mds1]

Just reread this. There are definitely more causes of reasons this can fail aside from those two, so maybe just Deployment failed as the error message

[lonerapier]

@ZeroEkkusu just have to check for zero address reverts, right?

Should I add tests for failures as well?

[ZeroEkkusu]

@dsam82 Yes. Will you also standardize the other error messages?

I'd suggest this format based on Matt's suggestions:

require(condition, "ContractName functionName(type,type): Error message here.");

Should I add tests for failures as well?

Yes, please. But @dsam82 this part is not too important; you don't have to do it unless you already had an idea for a test.

[lonerapier]

I had an idea of creating a simple reverting contract and then using deployCode to check for zero address reverts.

Currently encountering an error: expectRevert is not working even though revert is being thrown.

Will create a draft PR soon.