Giter Site home page Giter Site logo

Comments (2)

daniel-rikowski avatar daniel-rikowski commented on August 25, 2024

I have a similar monkey patch for ignoring a self-signed certificate in development.

Perhaps it would be better to use a "downloader proc" instead of providing individual parameters.

Something like this:

def load(url)
  uri = uri_for_url(url) || return
  downloader = Rails.config[:network_downloader] || ->(uri) { Net::HTTP.get(uri) }
  downloader.call(uri)
end
Premailer::Rails.config.merge!(
  # With SSL options:
  network_downloader: lambda do |uri|
    request = Net::HTTP::Get.new(uri.path)
    response = Net::HTTP.start(
        uri.host, uri.port, 
        use_ssl: uri.scheme == 'https', 
        verify_mode: OpenSSL::SSL::VERIFY_NONE) do |https|
      https.request(request)
    end
    response.body
  end,

  # With proxy:
  network_downloader: lambda do |uri|
    request = Net::HTTP.new(uri.host, uri.port, ENV['egress_proxy_host'], ENV['egress_proxy_port'])
    request.use_ssl = uri.scheme == 'https'
    response = request.get(uri.request_uri)
    response.body  
  end
)

from premailer-rails.

fphilipe avatar fphilipe commented on August 25, 2024

Not going to support this. But you have a working solution 😊 πŸ’πŸ©Ή

from premailer-rails.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.