Translations are not detected in *.ts files

[michaelz]

Translations are not detected in *.ts files

[FranciscoKnebel]

Hey @michaelz, thanks for the kind words.
In regard to your question, yes, it indeed does not cover those use cases.

Translate pipe in another line would probably be possible to catch by just tweaking the regex a bit, but the translate service one is tougher and the most important, and on the project I used this we had no coverage to get these types of strings, unfortunately.
Perhaps checking also for lines that include "translateService" and extracting from there? (the translateService can be named anything, so would also add an option to change the service name it looks for).

If you have any suggestions, feel free to open a PR and I can review and update the package.

[michaelz]

I used the following regex to make it work :

/[0-Z_]{3,}(\.[0-Z_]{3,})*(\.(one|other))? (and then removing the matched.map...) but this would only work in my case because I have this specific key naming rule in my code, and I only had to check for unused translations, not missing ones...

This wouldn't really be a good candidate for changing this library's code.

For those interested, I just replaced this:

...const e=r.readFileSync(t,{encoding:"utf8"}).match(/({{)?( )(\'|\")((\w|\-)\.?)(\'|\")( )\|( )translate( )(}})?/g);let n=[];return e&&e.length>0&&(n=e.map((t=>t.match(/(\'|\")(.)?(\'|\")/)[2]))),n})(t).forEach((e=>{const n=Pn.get(e)...

with this

...const e=r.readFileSync(t,{encoding:"utf8"}).match(/[0-Z_]{3,}(\.[0-Z_]{3,})*(\.(one|other))?/g);let n=[];return e&&e.length>0&&(n=e.map((t=>t))),n})(t).forEach((e=>{const n=Pn.get(e);...

in the actual generated code (I know it's ugly...)