Giter Site home page Giter Site logo

Comments (3)

francoischalifour avatar francoischalifour commented on May 20, 2024

You need to attach the zoom to each image added to the DOM. The lib is not observing the DOM for changes.

If I miss your point, please explain further.

from medium-zoom.

KsCorrales avatar KsCorrales commented on May 20, 2024

okay i resolve the problem, i use jquery "live on"

$('body').on('DOMNodeInserted', '[data-action="zoom"]', function () {
    mediumZoom('[data-action="zoom"]');
});

but now i have a problem, the plugin create an image at the bottom of the code ok good, but when i out zoom and i open zoom again, create 2 images in the dom and to close y need 2 clicks out of image, when close i click again and create 3 images elements and so on :S

from medium-zoom.

francoischalifour avatar francoischalifour commented on May 20, 2024

That's because you're applying the zoom multiples times on the same images. You should check beforehand if the image has the medium-zoom-image class.

mediumZoom(
  Array.from(document.querySelectorAll('[data-action="zoom"]'))
    .filter(img => !img.classList.contains('medium-zoom-image'));
);

A better way to do it would be to use the event target of the DOMNodeInserted callback:

document.body.addEventListener('DOMNodeInserted', function (event) {
  mediumZoom(event.target);
});

This is plain JavaScript (see reference), it should work with jQuery as well.

Hope it helps!

from medium-zoom.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.