Giter Site home page Giter Site logo

Comments (2)

francoischalifour avatar francoischalifour commented on July 22, 2024 6

I haven't dug very much into the behavior but I think that the issue comes from somewhere else.

We dismiss the zoom when (simplified):

  • The zoomed image is clicked
  • The scroll position exceeds the original scroll position + the offset (40px by default)

My assumption is that when you pinch the image, the scroll position changes, causing the zoom to be dismissed.

We would therefore need to add a new condition in the scroll handling function to not close the zoom when the image is pinched:

const _handleScroll = () => {
if (isAnimating || !active.original) {
return
}

From reading the documentation on ToucheEvent.touches, it seems like we can change the state on touchstart and touchend when touches.length >= 2 (as pointed out by @tuelsch) to return early in this function.

That's only my assumption based on what I tried blindly on my phone.

If you've got time, feel free to send a PR!

from medium-zoom.

gfellerph avatar gfellerph commented on July 22, 2024

Can a pinch gesture be detected by inspecting the event.touches >= 2 property? This means that two or more fingers/pointers are involved. Say, if more than two "touches" are detected, don't close the image and let the browser do its thing.

from medium-zoom.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.