Comments (7)
The reason is that I'm still technically new to Rust! I'll add it in, thanks for the report!
from exe-rs.
Looking through what I'd need to do to implement this properly, this will probably result in a useful refactor of error codes (e.g., Error::InvalidRVA should also return the offending RVA)! Not sure how long the refactor will take, but I doubt it would be too long. For now to deal with the lack of Display formatting I usually just use debug printing for the error codes to figure out what's going on (i.e., println!("{:?}", error)).
from exe-rs.
Right now I'm using lots of .map_err()
to map to my own errors. Not having the std::error::Error
impl is very annoying because it makes the code more explicit, especially when it comes to interop with other error types/crates. I've been using the thiserror
crate for my errors and wanted to generate a From
impl for your errors but thiserror
refuses to do that because your errors don't implement std::error::Error
yet
I've been using the Debug
impl as a workaround for printing already 😄
from exe-rs.
Thanks for the clarification, that's helpful to know!
from exe-rs.
Okay, the trait is implemented for errors and errors are a bit more helpful! Thanks again for reporting!
from exe-rs.
Did you somehow overwrite the 0.4.4 version on crates.io with your new code?
I pulled my project on a different pc and it has exe = "0.4.4"
in dependencies and now everything broke. I assume if I do cargo clean
and then try compiling again on my pc it would break too :(
Edit: Nevermind, exe = "=0.4.4"
works, I never had any crate that had "breaking" changes in a minor version update before 😄
from exe-rs.
Yeah this will break things because of how much I modified the errors! I got like 100s of errors in exe-rs when I did that, haha! Glad you fixed it!
from exe-rs.
Related Issues (11)
- BufferSearch search performance HOT 3
- How to get pictures and save them HOT 7
- .Net bin parsing issue HOT 6
- Intended way to use CChar strings eg Section Name HOT 1
- get_section_by_name requres a String instead of an &str HOT 4
- chrono dep pulls in time version with CVE-2020-26235 HOT 3
- Use cargo fmt
- Release the code for the tests
- dll support for ressource directory? HOT 2
- Code from example directory panics for Rufus executable on Windows HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from exe-rs.