Generic support or unnecessary cast for Parcelables

[frankiesardo]

Generic support or unnecessary cast for Parcelables

[frankiesardo]

ArrayList double cast is necessary to force type erasure #25

You're right, Parcelable cast is not needed, but it is part of the same typecast family and keeping it out is more a cognitive load than including it. Runtime penalty is basically non-existent.

If there are more pressing reasons to remove it I'm happy to give it a second though.

[MikolajKakol]

Thanks for looking into it. Although you probably right about second part of my question, you haven't written what you think about generics support.

Let's say I have base ProductActivity class that is responsible to display Product. Now many classes inherits from Product so I want to declare my Activity as ProductActivity<T extends Product> and have protected T product variable that would be persisted using @Icepick. Having this situation Icepick would generate code like

target.product= (T) savedInstanceState.getParcelable(BASE_KEY + "product");

The T type is unknown so this code won't compile. This cast is unnecessary, it might be impossible to have type mismatch here.

[frankiesardo]

You're right, that is actually a bug. I think the typecast should be smarter, otherwise simply removing "Parcelable" from the typecast list won't solve the issue. I'll keep this thread open

[IlyaEremin]

Any progress here?

[frankiesardo]

Yes, there is a new version ready to be published soon. Would you like to
try a snapshot version?
On 12 Feb 2015 10:44, "Ilya Eremin" [email protected] wrote:

Any progress here?

—
Reply to this email directly or view it on GitHub
#35 (comment).

[IlyaEremin]

Yeap, I would be happy if you would upload snapshot.

[frankiesardo]

This is the release candidate:

dependencies {
  compile "frankiesardo:icepick:3.0.0-SNAPSHOT"
  provided "frankiesardo:icepick-processor:3.0.0-SNAPSHOT"
}
repositories {
    mavenCentral()
    maven {
      url "https://clojars.org/repo/"
    }
}

[frankiesardo]

Fixed with 460e7c8