Comments (13)
Not as easy as it looks like. I'm using mustache for easy template rendering, thus adding an external dependency that is hosted in Clojars.
It's a one-liner to add clojars repo to your gradle builds and it's easy if you use Maven as well. If that becomes an issue I might consider dropping mustache templating.
I'll leave this issue open for discussion.
from icepick.
Well, you are right, it is not too hard. Group ID change and manual repository resolving confused me a bit. Personally I just don’t like the idea of a possible situation when every library forces repository declaration. Plus, reliability of Clojars is not as great as Central (only theoretically of course, there is no doubt that Clojars is totally fine and stable). Your call anyway!
from icepick.
+1 for Maven Central or JCenter 👍
from icepick.
+1 for a centralized repo.
from icepick.
+1 👍
from icepick.
+1
from icepick.
I see many benefits of using clojars (accessing all clojure libraries, artefacts instantly available, no manual steps required and my setup publishes snapshots on every commits, etc.).
Moving to Maven means reimplementing mustache templating manually or switching to something inferior, potentially adding bugs to the library.
If there are no other reasons on the users side rather than "I don't want to add a one-liner to my Gradle build file" then no matter how many +, it is not moving away from Clojars anytime soon.
from icepick.
My initial personal concern was more about unification than against Clojars. There is already some controversy about repositories and it starts to disturb me. We already have Maven Central, jCenter (which actually tries to superset Central), Clojars, JitPack and so on. But I must say it is not anyone’s fault, maybe Central apply rules are kind of outdated and complex too much, which causes portion of the trouble.
Anyway, I don’t see any technical reasons to move to Central. Maybe resolution time is a bit longer with Clojars applied?
I’m closing the issue, feel free to reopen it if you have any technical concerns like @frankiesardo said.
from icepick.
A side effect of using Clojure is messing APK a little. There are some files embedded in the package which we clearly don’t want to have.
project.clj
META-INF/leiningen/frankiesardo/icepick/project.clj
Yes, it is is possible to configure android.packagingOptions.exclude
. Yes, it is not a biggie. But this and additional repository declaration in each project is kind of annoying.
And yes, Java is “boring” and so on, but JavaPoet is not that bad. Just saying.
from icepick.
It shouldn't be too hard to exclude those files from icepick jars, let me have a look.
If done properly nobody should be able to tell a Clojure jar from a Java one. Just saying
from icepick.
Agreed! ✨
from icepick.
Fixed in 3b6ab14
from icepick.
Thanks!
from icepick.
Related Issues (20)
- Need a tutorial
- Add support for visibility state HOT 3
- Unable to pre-dex exception HOT 2
- Build fails with java.lang.ExceptionInInitializerError HOT 2
- Fix missing @Override in generated classes HOT 1
- Please release 3.2.0
- Any chance to release under Apache-2.0 ??? HOT 1
- How to save state of serialize object.
- java.util.HashMap cannot be cast to java.util.LinkedHashMap HOT 2
- what I did wrong? HOT 1
- Support incremental annotation processing HOT 11
- Gradle error :app:javaPreCompileDebug
- Process 'command 'C:\Program Files\Android\Android Studio\jre\bin\java.exe'' finished with non-zero exit value 1 HOT 3
- Bundler that modifies object in get method
- Could not find icepick-processor.jar in jcenter() HOT 7
- Guys i am trying to run my gradle project but it is showing some errors, can someone help me
- The proguard rule does not work on MI4 (Android 4.4)
- Execution failed for task ':client-app:bootRun'. > Process 'command 'C:\Program Files\Java\jdk1.8.0_161\bin\java.exe'' finished w ith non-zero exit value 1 HOT 3
- Bug: icepick ver3.2.0:「Developer options: ON> Dont keep activities: ON」, when re-generating Activity, instance state value can not be obtained in Icepick.restoreInstanceState
- module jdk.compiler does not export com.sun.tools.javac.processing to unnamed module HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from icepick.