test DSGE fails

[frbny-dsge]

test DSGE fails

[caimichael]

Hey @finmod , we actually haven't tested our package in the 1.x.x versions, since we were just recently able to transition to julia 0.7.0. I realize that we tagged with compatibility being in 1.x.x versions (as advised by the Julia Computing team) as shown in our Project.toml file, but we probably should test more extensively in 1.x.x. I'll try to get back to you tomorrow if the bug fix is quick.

[caimichael]

Hi @finmod. I've made a few bug fixes and re-submitted a patch release, v0.5.1 of DSGE.jl to incorporate them. They should be approved shortly and when they are, you can try to run the tests again. They pass for certain on v1.0.x versions, but because we don't have v1.1.x versions available on our cluster, I wasn't able to test on that version. We technically have not tested for compatibility for that minor version of Julia, so I would not recommend using our package on 1.1.x until we get there (or you could use it at your own risk!)

[finmod]

Thank you. With 1.1.1, test DSGE fails in load.data.jl that you visited recently.

Test Summary: | Pass Total
HP Filter and missing data handling | 4 4

• data/load_data.jl
  Test various forms of data loading: Error During Test at C:\Users\Denis.julia\packages\DSGE\kGlBP\test\data\load_data.jl:6
  Got exception outside of a @test
  KeyError: key "HOME" not found
  Stacktrace:
  [1] (::getfield(Base, Symbol("##434#435")))(::String) at .\env.jl:76
  [2] access_env(::getfield(Base, Symbol("##434#435")), ::String) at .\env.jl:14
  [3] getindex(::Base.EnvDict, ::String) at .\env.jl:76
  [4] top-level scope at C:\Users\Denis.julia\packages\DSGE\kGlBP\test\data\load_data.jl:8
  [5] top-level scope at C:\cygwin\home\Administrator\buildbot\worker\package_win64\build\usr\share\julia\stdlib\v1.1\Test\src\Test.jl:1083
  [6] top-level scope at C:\Users\Denis.julia\packages\DSGE\kGlBP\test\data\load_data.jl:8
  [7] include at .\boot.jl:326 [inlined]
  [8] include_relative(::Module, ::String) at .\loading.jl:1038
  [9] include(::Module, ::String) at .\sysimg.jl:29
  [10] include(::String) at .\client.jl:403
  [11] top-level scope at C:\Users\Denis.julia\packages\DSGE\kGlBP\test\runtests.jl:43 [inlined]
  [12] top-level scope at .\none:0
  [13] include at .\boot.jl:326 [inlined]
  [14] include_relative(::Module, ::String) at .\loading.jl:1038
  [15] include(::Module, ::String) at .\sysimg.jl:29
  [16] include(::String) at .\client.jl:403
  [17] top-level scope at none:0
  [18] eval(::Module, ::Any) at .\boot.jl:328
  [19] exec_options(::Base.JLOptions) at .\client.jl:243
  [20] _start() at .\client.jl:436
  Test Summary: | Error Total
  Test various forms of data loading | 1 1
  ERROR: LoadError: LoadError: Some tests did not pass: 0 passed, 0 failed, 1 errored, 0 broken.
  in expression starting at C:\Users\Denis.julia\packages\DSGE\kGlBP\test\data\load_data.jl:6
  in expression starting at C:\Users\Denis.julia\packages\DSGE\kGlBP\test\runtests.jl:40
  ERROR: Package DSGE errored during testing

(v1.1) pkg>

[caimichael]

@finmod, the new patch release has not been tagged yet, so did you check out master? I'm confused how you moved past your previous error. Nonetheless, we will not be patching any 1.1.x related bugs until we fully upgrade to that version.

[finmod]

Yes, I am on master and I also build DSGE for good measure. You are right about tagging. Will retry tomorrow.

[JohannesNaegele]

Exactly the same problem here, data loading errors. Is there any workaround so that I can get started with DSGE.jl on Julia 1.x? With this error I can't even run run_default.jl...

[chenwilliam77]

@JohannesNaegele If it's the error
KeyError: key "HOME" not found
perhaps your Julia set up does not have the ENV["HOME"] variable set. Otherwise, please show the error so we have an idea of what's going on. Given that the build is passing, I'm not sure the issue is with DSGE.jl in its current state.

[JohannesNaegele]

Yeah, it seems to be related to my installation and/or Windows and the "HOME" key: If I try it on Linux, it works. Frankly speaking, my whole Julia setup on Windows is kinda messy, therefore I don't think it does make too much sense figuring out the exact reason. Nevertheless, I ran into new errors on Linux (I will open a new issue).