Giter Site home page Giter Site logo

Comments (7)

ayushgupta9906 avatar ayushgupta9906 commented on May 31, 2024 1

I want to work on this issue. Please Assign this to me.
Thanks

from freecad.

FEA-eng avatar FEA-eng commented on May 31, 2024

Right, it shouldn't belong to TD. It should probably go to Draft like Shape2DView but Part would also make sense.

from freecad.

luzpaz avatar luzpaz commented on May 31, 2024

cc @Roy-043

from freecad.

Roy-043 avatar Roy-043 commented on May 31, 2024

Draft already has Draft_Shape2DView. That tool relies on TD code internally. Adding TechDraw_ProjectShape to Draft seems redundant.

from freecad.

PaddleStroke avatar PaddleStroke commented on May 31, 2024

Hmm this Shape2DView seems very similar to ProjectShape. But I don't know these tools well so I can't say for sure. Perhaps it is not worth keeping both then? Should be just remove ProjectShape? @yorikvanhavre ?

from freecad.

yorikvanhavre avatar yorikvanhavre commented on May 31, 2024

Draft_Shape2DView has a few additional functionalities such as the ability to fill closed areas or show cut lines. OTOH TD projectShape is probably faster. So at the moment although they are similar I can't say one should be removed.

Having both in Draft is a possible, but IMHO this will not make things easier to the user... There will now be two very similar tools one next to the other.

Having it in Part wouldn't be good because it would make Part depend on TechDraw when it's currently the contrary.

What about keeping it in TD but putting in some kind of "utils" submenu?

from freecad.

PaddleStroke avatar PaddleStroke commented on May 31, 2024

If Draft_Shape2DView is a super set of TechDraw_ProjectShape, then there is no reason to keep it around. Unless it is indeed significantly faster. Could you please make a little test to see if it is actually faster?

  • If it is not faster then we can just remove TechDraw_ProjectShape.
  • If it is faster, is there not a way to make Draft_Shape2DView faster by using what makes TechDraw_ProjectShape faster?
  • If it is faster but speed cannot be transfered to Draft_Shape2DView, then having both in draft together would make most sense imo, in a command group for example. With tooltip that explain the differences.

If we move to Part, we don't have to make Part depend on TD, we can move the code to Part probably not just the tool.

Leave in TD but only in menu, I think this is not as good as a solution. It will just be completely hidden and cluttering a bit.

from freecad.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.