BIM: buildingsmart-tech.org links in code no longer work

[Roy-043]

BIM: buildingsmart-tech.org links in code no longer work

[3x380V]

A naive solution looks like:

diff --git a/src/Mod/BIM/bimcommands/BimPreflight.py b/src/Mod/BIM/bimcommands/BimPreflight.py
index 9e3434217c..4453f16fa6 100644
--- a/src/Mod/BIM/bimcommands/BimPreflight.py
+++ b/src/Mod/BIM/bimcommands/BimPreflight.py
@@ -894,7 +894,7 @@ class BIM_Preflight_TaskPanel:
                     "\n"
                     + translate(
                         "BIM",
-                        "Verify which properties a certain property set must contain on http://www.buildingsmart-tech.org/ifc/IFC4/Add2/html/annex/annex-b/alphabeticalorder_psets.htm",
+                        "Verify which properties a certain property set must contain on https://standards.buildingsmart.org/IFC/DEV/IFC4_2/FINAL/HTML/annex/annex-b/alphabeticalorder_psets.htm",
                     )
                     + "\n\n"
                 )
diff --git a/src/Mod/BIM/utils/buildPsets.py b/src/Mod/BIM/utils/buildPsets.py
index 4e8d508344..f00f41b9d5 100644
--- a/src/Mod/BIM/utils/buildPsets.py
+++ b/src/Mod/BIM/utils/buildPsets.py
@@ -33,7 +33,7 @@ MAXTRIES = 3
 # read the pset list
 print("Getting psets list...")
 u = urllib2.urlopen(
-    "http://www.buildingsmart-tech.org/ifc/IFC4/Add2/html/annex/annex-b/alphabeticalorder_psets.htm"
+    "https://standards.buildingsmart.org/IFC/DEV/IFC4_2/FINAL/HTML/annex/annex-b/alphabeticalorder_psets.htm"
 )
 p = u.read()
 u.close()
@@ -47,7 +47,7 @@ for i, pset in enumerate(psets):
     for j in range(MAXTRIES):
         try:
             u = urllib2.urlopen(
-                "http://www.buildingsmart-tech.org/ifc/IFC4/Add2/html/psd/Pset_"
+                "https://standards.buildingsmart.org/IFC/DEV/IFC4_2/FINAL/HTML/psd/Pset_"
                 + pset
                 + ".xml"
             )

[yorikvanhavre]

The IFC documentation has the bad habit of changing locations quite often :)
And there is unfortunately apparently no "default" location that would "always work".

I think we could maybe define an IFC_DOCS_ROOT_URL variable somewhere to be used everywhere in BIM so it's easy to update next time

[3x380V]

Agree. And as it turns out translations would change with IFC_DOCS_ROOT_URL, I think we should change urls in all translated strings to something like this

translate(
    "BIM",
    "Verify which properties a certain property set must contain on %1",
).replace("%1", IFC_DOCS_ROOT_URL + "/annex/annex-b/alphabeticalorder_psets.htm")

to save touching them on random url change. As talk is cheap, I'll prepare PR for that.

[yorikvanhavre]

That would be cool! Yes, please do! Thanks!!

[3x380V]

Done as #14258. Please note that only buildPsets.py is tested while patch changing translation strings is not.