The visibility icon needs to work with more styles

[NomAnor]

The visibility icon needs to work with more styles

[Reqrefusion]

This has nothing to do with the icon. As a general solution, changing the icon according to the text color. Also, the eye suggested by Kadet is obviously better.

[NomAnor]

As a general solution, changing the icon according to the text color.

I agree, but Kadets code suffer pixelation on my Setup (4k). This needs to be addressed before chaging it.

Also, the eye suggested by Kadet is obviously better.

That is a matter of opinion not fact and thats why this issue exists. I'm not against the icon change.

The transparent background inside of the icon makes the lines look to thin in the overlay mode. This could be fixed with a solid background on the inside. Or the generated outline needs to fill it, but this might not be easily possibe.

There are a lot of possible style variants and it might not be possible to support all of them without a lot of work to provide alternative icons by theme.

These setting with Kadets patch

look like this after a restart:

In my opinion this does not look good.

I don't know if there is an official list of style settings that should be considered, but at least the three options from the start assistant should look and work ok, ideally with and without overlay mode.

[kadet1090]

This is strange - in that case the eye icon should be black as the text is also black - then the icon looks as good as the text does. I'll check why this is the case. As the alternative I can add white fill to the icon so it will still have constant stroke that should help. I however agree that this can be done in another PR.

As for the pixelation - try changing QSize to (32, 32) that should help with the pixelation - I'm not able to test with 4k.

[NomAnor]

It seems that changing the themes in the preferences does not always change the style correctly.
Between changing the style in the preference window and restarting some parts seem to look different, but I have not investigated it.
It's not only the icon but also the outline of the text. There could be other bugs that are the culprit and not your code.

[MisterMakerNL]

I have some merge issues in my darkstyle PR which stops me from checking this out.
OVerlay code for the text color has also moved from Qwidget to Qtreeview, so maybe it fixes something here.