All the issues in the new stylesheets/themes.

[MisterMakerNL]

All the issues in the new stylesheets/themes.

[maxwxyz]

I'm in favor still dropping the Behave theme. Otherwise anyone can do a PR and add his own theme to FreeCAD and it gets bloated fast. So 3 official ones, easier to maintain and anyone is free to create one by himself and distribute it through the addon manager.
Otherwise I could change one color of dark slightly, make a PR with the theme and call it Darker and if more people do this we end up at the situation we have in the stable.
@FreeCAD/design-working-group any feedback on this?

[maxwxyz]

And there are still two dark themes. Behave has to be deleted too, you can only choose between two on the start page.

[kadet1090]

I'm in favor of adding FreeCAD prefix to "official" themes. Going with "Light" / "Dark" / "System" would be fine if we would not provide ability to create custom themes. With custom themes it will help distinguish the official themes from 3rd party ones.

[MisterMakerNL]

Fixed the overlay icons as mentioned by @kadet1090

Although only for the light theme atm.

[MisterMakerNL]

@MisterMakerNL thanks. Do you think it would be possible to submit a draft PR, so that we can help with testing the changes?

#14749
The lag fix is btw from kadet #14820

[MisterMakerNL]

Selection colors are wrong when overlay is not set to transparent:
https://forum.freecad.org/posting.php?mode=reply&t=88509

[maxwxyz]

• #14747
• #14729

[MisterMakerNL]

This needs to be implemented
#14592

[kadet1090]

Tested with Qt6 and Fusion as Qt Style.

1. Disappearing down arrow icon in toolbars:
   

2. Unnecessary padding for toolbar icons:
   

3. Hard to read text in hovered menu entries due to low contrast:
   

4. No padding for tool buttons in the status area:
   

5. Unnecessary border for toolbars in QStatusBar and QMenuBar:
   
   

6. hovering over table rows highlights only cell:
   

7. Unreadable Combo Box list due to low contrast:
   

8. Controls could use a bit more horizontal padding to look better and be more readable (https://medium.com/@manonpiette.pro/margins-and-padding-e4e9d0efa65d):
   

9. Checkboxes are quite small - it would be wise to make them a bit bigger.
   

10. Radio buttons are not rendered well:
    

11. Spacing for buttons in spinboxes is uneven:
    

12. Hovering over treeview in overlay mode hovers whole row (probably Qt6 issue, see: #13760):
    

13. Buttons in task panel have broken laoyut:
    

14. Expression icon is not aligned vertically:
    

15. Scrollbar border is uneven (look at top button):
    

16. Yellow for marking "clicked" button in overlay panels seems very odd:
    

17. Icon for expanding tree branch is too big:
    

18. Images for theme selection buttons are not centered:
    

19. Strange black bar close to few drop-down toolbar buttons:
    

[MisterMakerNL]

And there are still two dark themes. Behave has to be deleted too, you can only choose between two on the start page.

#13772 (comment)

[furgo16]

Thank you for the work in simplifying and upgrading the default themes. Some things I've noticed:

1. Toolbar separators are too dark on the Light theme. They might also need some horizontal padding (this might be the same as @kadet1090's point no. 19):
   
2. Notification window is clipped horizontally:
   
3. Active button highlight is nearly invisible. In this example, Cancel is active. The default Qt theme overlays a transparent color over the button's body to make it more clear:
   
4. Unnecessarily colored checkbox when using keyboard navigation and highlighting the active checkbox. This also applies to checking a checkbox (the checkbox itself is blue when clicking on it):
   
5. Misplaced downward chevron on the TabBar's "plus" button:
   
6. I got this error on the Tasks panel when unfolding one of the widgets: Could not create pixmap from qss:images_classic/Qsint_header_UnfoldOver_Blue-light.png
7. To be consistent with the "Classic" naming, the new themes should drop the "Theme" suffix from their name, resulting in "Light" and "Dark". It is clear that they are themes by the "Theme:" label next to them.
   
8. Active toggle button's background color in the commands toolbar makes icons less legible. It also raises visual attention unnecessarily. The Classic theme's dark gray is more neutral and addresses both issues (for the light theme at least)
   
9. When pressing a toggle button to make it checked, its right padding increases, displacing all subsequent buttons to the right:
   
10. Toggle buttons in the status toolbar (e.g. for the Draft Workbench) move when hovering over them:
    
11. Toggle buttons in the status toolbar (e.g. for the Draft Workbench, snap lock commands) with a chevron to expand have the chevron misplaced:
    
12. Unnecessary horizontal bar underneath buttons in the status toolbar:
    
13. Tooltips are surrounded by a (light gray? white?) frame that makes up for a strange effect in the transition between tooltip background color and tooltip shadow
    

[pierreporte]

1. The drop-down button arrow disappears at hover.
2. Menus don’t have a shadow.
3. Themes are still lagging, although it’s far better now.

OS: Ubuntu 23.10 (KDE/plasma)
Word size of FreeCAD: 64-bit
Version: 0.22.0dev.37819 (Git) AppImage
Build type: Release
Branch: main
Hash: 2ca9b6ef8036d5fd808f01205b66eb0424059e21
Python 3.11.9, Qt 5.15.13, Coin 4.0.2, Vtk 9.2.6, OCC 7.7.2
Locale: French/France (fr_FR)
Installed mods: 
  * BillOfMaterials-WB 0.0.7
  * CosmeticThread3D
  * OpenTheme 2024.5.16
  * Curves 0.6.39
  * CurvedShapes 1.0.9
  * sheetmetal 0.4.18

[MisterMakerNL]

Seems to be that the overlay isn't correct in classic/no-stylesheet.
https://forum.freecad.org/viewtopic.php?p=766453#p766453

[MisterMakerNL]

Although it's gonna be annoying to do but I want to suggest renaming the theme's too:

• Freecad Dark
• Freecad Light
• Freecad Classic

I made this up myself and definitely didn't steal this idea from Blender.

[furgo16]

I'd agree, for consistency. Although please consider also:

• Classic
• Dark
• Light

Why:

1. Simpler, shorter, straightforward to translate
2. It already conveys the essential information about the theme
3. Adding the "FreeCAD" prefix does not convey any additional necessary information. The user is using FreeCAD and changing the preferences to switch themes, so it's already clear to them that they are looking at a FreeCAD-specific theme.

This is of course just my opinion, feel free to disagree!

It might be worth looking at a couple of other pieces of software that have these 3 basic themes to see how they handle it for comparison.

Update:

• GitHub Desktop:
• Visual Studio:
  
• Blender:
  
• GIMP:
  

[MisterMakerNL]

I can see why Blender did it. You say adding Freecad doesn't add any information, but it actually says it parts of Freecad.
And with the option to mix in theme's from addons, it is useful to give this information.

[MisterMakerNL]

Seems to be that the overlay isn't correct in classic/no-stylesheet. https://forum.freecad.org/viewtopic.php?p=766453#p766453

Fixed it by setting an overlay stylesheet 84391e2

[pierreporte]

Also in favor of dropping the theme. FreeCAD should concentrate on two carefully designed ones and the classic theme (at least in medium term for this one).

[onekk]

Applying a stylesheet need sometimes a repaint action, I've discovered when fiddling with them, at least on Qt5, I have published on FreeCAD forum a post some time ago with python code that will trigger the repaint action.

Sadly not at my PC for some time to post here the relevant code (three lines in Python).

Maybe in a couple of days I will post here these lines.

[MisterMakerNL]

88ae90e
Radio buttons reported by @kadet1090 should be fixed now, I boosted all icons sizes since I saw artifacts on lower resolution.
Only the Qsint icons stay the same.
Should look like this now:

[MisterMakerNL]

Fixed the spinbox buttons in light

[MisterMakerNL]

Some small fixes:

[furgo16]

@MisterMakerNL thanks. Do you think it would be possible to submit a draft PR, so that we can help with testing the changes?

[onekk]

Hello, I've found the code now:

This function will do the magic when applying "role" to labels, i.e a dynamic property as described in:

Customizing Using Dynamic Properties¶

def set_wd_prop(wid, prop, val):
    """Set Qt Widget property."""
    wid.setProperty(prop, val)
    wid.style().unpolish(wid)
    wid.style().polish(wid)

set_wd_prop(label, "role", "edit")

With this stylesheet (I have many of them for different 'roles')

            "QLabel[role='edit'] {"
            "    font-weight: bold;"
            "    font-style: normal;"
            "    text-decoration: none;"
            "    border: 2px outset gray;"
            "    border-radius: 5px;"
            "    padding: 5px;"
            "}"

The point is that the property change is not applied so you have to force it, with this part of the above code:

    wid.style().unpolish(wid)
    wid.style().polish(wid)

Maybe the same is not working on some other things.

Sadly, an accident in my computer, has deleted all my saved Firefox bookmarks, so I can't present the saved links from where I have taken the code.

Hope it maybe help in some cases.

Kind regards

Carlo D.

[MisterMakerNL]

Text select seems to be broken.
Text select in task window turns white.
Both seems to be an overlay issue.

[MisterMakerNL]

I renamed the theme's too Freecad Dark/Light/classic.
Also re-ordered startpage so the active theme is first doesn't fix this issue but improves it: #14819