Comments (8)
@tchaffee @tbushman nice! Glad this one was finally resolved. Everything is looking in awesome shape thanks to you guys!
from testable-projects-fcc.
@no-stack-dub-sack What is the expected behavior for those buttons?
from testable-projects-fcc.
@no-stack-dub-sack Has this gone off your radar? I'm happy to try to fix this if I can understand what the expected behavior is.
from testable-projects-fcc.
@tchaffee thanks for the reminder. This one went unnoticed.
To be honest, I'm not sure what the expected behavior is. I think it is to select and replay one individual test. Sometimes it half works in codepen, and the test suite will select and only run one test, but most of the time it just goes to a blank page.
I tried noodling around at some point a while ago, but couldn't produce any different behavior. Ideally we could just remove or disable them I think, since most of our tests run pretty quickly. Although if they are meant to just select and run one particular test, it could be useful in the D3 tests or Pomodoro, any of those tests that don't happen pretty much instantaneously.
from testable-projects-fcc.
@no-stack-dub-sack Ok, thanks for the feedback. I'll look into it.
from testable-projects-fcc.
This does work, but it's not intuitive how it works. In order to see it working, you need to press our "Run Tests" button again, after which you'll see just that one test run. Unfortunately there is then no way to re-run all of the tests without refreshing the page.
What's happening is that the mocha arrows / buttons just execute mocha.run()
. However our test runner does mocha.run()
along with a bunch of other stuff like displaying the test results modal and updating the our buttons with the number. So we really shouldn't be allowing mocha or anything else to execute mocha.run()
on its own.
I see a few possible solutions:
- Try to override the mocha buttons with our code. This will probably be a bit of work to get everything in sync.
- Just hide those arrows with CSS.
- Long term @tbushman may have a solution as she mentioned in comments above.
For now, I think we should just change the CSS. Our tests are pretty fast even if you re-run every test each time. It's a quick fix, and I don't think anyone is using those arrows anyway, and we haven't had complaints. No one is going to miss them.
@QuincyLarson @tbushman @no-stack-dub-sack What do you think?
from testable-projects-fcc.
@tbushman I'll leave this to you then. I wouldn't much more than a few hours getting those arrow buttons to work though. I just don't think they are very useful. If someone wants to make the case that they are an important feature, I'm open to hearing about that.
from testable-projects-fcc.
@no-stack-dub-sack @tchaffee Awesome - thanks for surfacing this issue.
@tbushman thanks for helping tackle this. We will defer to you.
We are going to start sending a lot of traffic to beta - hopefully in the next 24 hours. Thanks to help from a ton of contributors like you all, we are on schedule for shipping beta by Christmas!
from testable-projects-fcc.
Related Issues (20)
- test issue when i'm working with survey project , test shows test failed list of tribute page HOT 1
- Test failing but test requirement has been met HOT 1
- getting an error on product landing page #landing test. it says the navbar should always be at the top of the page. the navbar is at the top of my page but i am still receiving the error. HOT 1
- FCC Personal Portfolio - Can't get Layout #3 test to pass regarding navbar and viewport HOT 2
- project verification script not detecting required id tags in my code HOT 1
- User Story #11: Within the form, there is a submit input with a corresponding id="submit" HOT 1
- Test scripts are not correct HOT 1
- Personal Portfolio Project Bugs
- i think this is bog, 3 hour i am trying HOT 1
- Pomodoro Clock #15 Test of "25 + 5" Test Suite May Be Yielding Incorrect Results HOT 3
- Survey Form Test Issues
- FCC: Tribute Page
- Potrfolio tests: typo in #Content test number 4
- the test is not running HOT 1
- Markdown Preview tests not compatible with Vue HOT 1
- TypeError: Cannot read property '1' of null for Pomodoro clock. Why?????!!!!!!! HOT 1
- Issue with image running Tribute Page tests HOT 2
- Dependency Dashboard
- Build a JavaScript Calculator tests typo HOT 3
- incomplete fix for 25+5 with React@18 in #1485
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from testable-projects-fcc.