Comments (6)
@paycoguy @Christian-Paul ☝️
from testable-projects-fcc.
@tom-p-uk Thanks Tom for building these D3 projects! I believe we can validate the scatter plot whether the axis values are ascending or descending. It'll just make the code a bit more complicated.
from testable-projects-fcc.
@paycoguy @Christian-Paul @QuincyLarson I need some direction for this failing test. @no-stack-dub-sack you might want to chime in?
The test does not do what it says it does. The test says "The data-yvalue and its corresponding dot should align with the corresponding point/value on the y-axis." But there is no code in that test that checks alignment with the y-axis. What it does, as @tom-p-uk points out, is to check if the cy
values (vertical position) of the dots are in ascending order after sorting the dots by data-yvalue
. In plain English, it checks if dots with a smaller data-yvalue (faster time) appear above dots with larger data-yvalue
.
I looked into seeing if I could check if the dots align correctly with the y-axis labels and it looks pretty complicated. Important also that d3 does that work for you, so I'm not sure how much value that test has.
In the meantime, I think the best I can do is to fix the existing test wording so it better describes what it is testing. It would clarify what's being testing, along with making sure the values are ascending:
"The vertical position of each dot must be related to the data-yvalue attribute of the dot, and dots with a faster time (smaller data-yvalue) should be above dots with a longer time (larger data-yvalue)"
This test, along with test 12, "I can see that the range of the y-axis labels are within the range of the actual y-axis data" should be enough to ensure the dots are aligned with the y-axis, considering that d3 is the one doing that work for the camper.
Thoughts please?
from testable-projects-fcc.
@tbushman I forgot you are working on some d3 issues yourself. If you have any ideas on the above, your comments are of course welcome.
from testable-projects-fcc.
@tbushman that's excellent because I was stuck. You're thinking about this more creatively than I am and I'm looking forward to seeing what you come up with.
from testable-projects-fcc.
I looked into seeing if I could check if the dots align correctly with the y-axis labels and it looks pretty complicated.
We tried to do this as well and couldn't find a good way to do it.
I believe I tried making this test work whether the axis was ascending or descending, but the resulting code became really long.
"The vertical position of each dot must be related to the data-yvalue attribute of the dot, and dots with a faster time (smaller data-yvalue) should be above dots with a longer time (larger data-yvalue)"
This sounds alright with me.
from testable-projects-fcc.
Related Issues (20)
- test issue when i'm working with survey project , test shows test failed list of tribute page HOT 1
- Test failing but test requirement has been met HOT 1
- getting an error on product landing page #landing test. it says the navbar should always be at the top of the page. the navbar is at the top of my page but i am still receiving the error. HOT 1
- FCC Personal Portfolio - Can't get Layout #3 test to pass regarding navbar and viewport HOT 2
- project verification script not detecting required id tags in my code HOT 1
- User Story #11: Within the form, there is a submit input with a corresponding id="submit" HOT 1
- Test scripts are not correct HOT 1
- Personal Portfolio Project Bugs
- i think this is bog, 3 hour i am trying HOT 1
- Pomodoro Clock #15 Test of "25 + 5" Test Suite May Be Yielding Incorrect Results HOT 3
- Survey Form Test Issues
- FCC: Tribute Page
- Potrfolio tests: typo in #Content test number 4
- the test is not running HOT 1
- Markdown Preview tests not compatible with Vue HOT 1
- TypeError: Cannot read property '1' of null for Pomodoro clock. Why?????!!!!!!! HOT 1
- Issue with image running Tribute Page tests HOT 2
- Dependency Dashboard
- Build a JavaScript Calculator tests typo HOT 3
- incomplete fix for 25+5 with React@18 in #1485
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from testable-projects-fcc.