XML Importer Not Setting "Value" with Float Datatype

[freeopcua]

XML Importer Not Setting "Value" with Float Datatype

[zerox1212]

Update:
I found the problem.

    def _parse_value(self, el, obj):
        for val in el:
            ntag = self._retag.match(val.tag).groups()[1]
            obj.valuetype = ntag
            if ntag in ("Int32", "UInt32"):
                obj.value = int(val.text)
            elif ntag in ('ByteString', 'String'):
                mytext = val.text.replace('\n', '').replace('\r', '')
                # obj.value.append('b"{}"'.format(mytext))
                obj.value = mytext
            elif ntag == "ListOfExtensionObject":
                self.logger.info("Value type not implemented: %s", ntag)
            elif ntag == "ListOfLocalizedText":
                self.logger.info("Value type not implemented: %s", ntag)
            else:
                self.logger.info("Value type not implemented: %s", ntag)

Should probably throw a TODO in that code since the XML importer doesn't even support the OPC UA base variants.

For now I added this code:

elif ntag in ("Float"):
      obj.value = float(val.text)

If I get time I will fork and implement all the base types.

[zerox1212]

So, another part of this issue with the importer.

The code that checks for a value won't write a "0.0" to the variable node.

    def add_variable(self, obj):
        ...
        if obj.value:
            attrs.Value = ua.Variant(obj.value, getattr(ua.VariantType, obj.valuetype))

This if statement should probably check for null's instead (is not None), but I don't know if this would cause problem with other value data.

[oroulet]

Yes parsing of values is half implemented. There is a bug for it. Would be
nice if you could fix it.

On Thu, Oct 29, 2015, 17:57 zerox1212 [email protected] wrote:

So, another part of this issue with the importer.

The code that checks for a value won't write a "0.0" to the variable node.

def add_variable(self, obj):
    ...
    if obj.value:
        attrs.Value = ua.Variant(obj.value, getattr(ua.VariantType, obj.valuetype))

This if statement should probably check for null's instead.

—
Reply to this email directly or view it on GitHub
#53 (comment)
.

[zerox1212]

After using the XML to import nodes, how can I access the nodes created by the server? For example if I want to subscribe to one.
server.get_node returns a node object even if the node doesn't exist.
Is there a way to get all the nodes that exist on the server?

[oroulet]

get_node just constucts an Node object. If you want if the node is valid call a method from it.
it looks like you create a node which is child of node i=30001. so get that node and call get_children og get_child

s there a way to get all the nodes that exist on the server?

A server has so many nodes, you do not want to do that....

[zerox1212]

I got some time to add a few fixes to the xml importer. I submitted a pull request. I hope I did it correct, it's my first pull request ever.

[zerox1212]

Quick question:
How can I import the NodeID as String instead of Numeric? NodeID 30,000 isn't very nice.

[oroulet]